Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed)

Created:
8 years, 10 months ago by not at google - send to devlin
Modified:
8 years, 10 months ago
CC:
chromium-reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, benwells
Visibility:
Public.

Description

Make registering custom hooks with schema_generated_bindings.js safer and stricter, by automatically prefixing the API's namespace to the set* methods (e.g. setHandleRequest), and throwing an exception if an unrecognised name is passed into a set* method. Also convert " to ' because it was simpler to script, and because it's the correct style. BUG= TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=123910

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : reabas #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -122 lines) Patch
M chrome/renderer/resources/extensions/browser_action_custom_bindings.js View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/chrome_private_custom_bindings.js View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/context_menus_custom_bindings.js View 1 2 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/renderer/resources/extensions/devtools_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/experimental.declarative_custom_bindings.js View 1 2 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 1 2 3 4 5 5 chunks +26 lines, -30 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_handler_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/i18n_custom_bindings.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/input.ime_custom_bindings.js View 1 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/omnibox_custom_bindings.js View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/page_action_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/page_actions_custom_bindings.js View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/page_capture_custom_bindings.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/schema_generated_bindings.js View 1 2 3 4 4 chunks +57 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/tts_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/web_request_custom_bindings.js View 1 2 8 chunks +20 lines, -23 lines 0 comments Download
M chrome/renderer/resources/extensions/windows_custom_bindings.js View 1 2 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
The only interesting changes are in schema_generated_bindings.js, everything else is done via a script (with ...
8 years, 10 months ago (2012-02-27 06:19:55 UTC) #1
koz (OOO until 15th September)
lgtm
8 years, 10 months ago (2012-02-27 22:27:26 UTC) #2
Aaron Boodman
lgtm
8 years, 10 months ago (2012-02-27 23:45:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/9423049/8006
8 years, 10 months ago (2012-02-27 23:47:41 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-28 05:52:06 UTC) #5
Change committed as 123910

Powered by Google App Engine
This is Rietveld 408576698