Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: chrome/renderer/resources/extensions/windows_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/web_request_custom_bindings.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/windows_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/windows_custom_bindings.js b/chrome/renderer/resources/extensions/windows_custom_bindings.js
index c97a3a1b9d0efcd6a7029cca7736f0fcb9b4413b..a0340f22181ce87107754d481b32f077bf4f126f 100644
--- a/chrome/renderer/resources/extensions/windows_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/windows_custom_bindings.js
@@ -11,12 +11,12 @@ native function GetChromeHidden();
GetChromeHidden().registerCustomHook('windows', function(api) {
var apiFunctions = api.apiFunctions;
- apiFunctions.setUpdateArgumentsPreValidate("windows.get", function() {
+ apiFunctions.setUpdateArgumentsPreValidate('get', function() {
// Old signature:
// get(int windowId, function callback);
// New signature:
// get(int windowId, object populate, function callback);
- if (arguments.length == 2 && typeof(arguments[1]) == "function") {
+ if (arguments.length == 2 && typeof(arguments[1]) == 'function') {
// If the old signature is used, add a null populate object.
newArgs = [arguments[0], null, arguments[1]];
} else {
@@ -25,13 +25,12 @@ GetChromeHidden().registerCustomHook('windows', function(api) {
return newArgs;
});
- apiFunctions.setUpdateArgumentsPreValidate("windows.getCurrent",
- function() {
+ apiFunctions.setUpdateArgumentsPreValidate('getCurrent', function() {
// Old signature:
// getCurrent(function callback);
// New signature:
// getCurrent(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
+ if (arguments.length == 1 && typeof(arguments[0]) == 'function') {
// If the old signature is used, add a null populate object.
newArgs = [null, arguments[0]];
} else {
@@ -40,13 +39,12 @@ GetChromeHidden().registerCustomHook('windows', function(api) {
return newArgs;
});
- apiFunctions.setUpdateArgumentsPreValidate("windows.getLastFocused",
- function() {
+ apiFunctions.setUpdateArgumentsPreValidate('getLastFocused', function() {
// Old signature:
// getLastFocused(function callback);
// New signature:
// getLastFocused(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
+ if (arguments.length == 1 && typeof(arguments[0]) == 'function') {
// If the old signature is used, add a null populate object.
newArgs = [null, arguments[0]];
} else {
@@ -55,12 +53,12 @@ GetChromeHidden().registerCustomHook('windows', function(api) {
return newArgs;
});
- apiFunctions.setUpdateArgumentsPreValidate("windows.getAll", function() {
+ apiFunctions.setUpdateArgumentsPreValidate('getAll', function() {
// Old signature:
// getAll(function callback);
// New signature:
// getAll(object populate, function callback);
- if (arguments.length == 1 && typeof(arguments[0]) == "function") {
+ if (arguments.length == 1 && typeof(arguments[0]) == 'function') {
// If the old signature is used, add a null populate object.
newArgs = [null, arguments[0]];
} else {
« no previous file with comments | « chrome/renderer/resources/extensions/web_request_custom_bindings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698