chrome/renderer/resources/extensions/omnibox_custom_bindings.js - Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/input.ime_custom_bindings.js ('k') | chrome/renderer/resources/extensions/page_action_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/omnibox_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

index f77ebd605b47ace59bdfd91b802e499ff3f12e01..13a3c61a2f84b6385977d5ee51a6dedea4d7747e 100644

--- a/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/omnibox_custom_bindings.js

@@ -83,14 +83,13 @@ GetChromeHidden().registerCustomHook('omnibox', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

var sendRequest = bindingsAPI.sendRequest;

- apiFunctions.setHandleRequest("omnibox.setDefaultSuggestion",

- function(details) {

+ apiFunctions.setHandleRequest('setDefaultSuggestion', function(details) {

var parseResult = parseOmniboxDescription(details.description);

sendRequest(this.name, [parseResult], this.definition.parameters);

});

- apiFunctions.setUpdateArgumentsPostValidate("omnibox.sendSuggestions",

- function(requestId, userSuggestions) {

+ apiFunctions.setUpdateArgumentsPostValidate(

+ 'sendSuggestions', function(requestId, userSuggestions) {

var suggestions = [];

for (var i = 0; i < userSuggestions.length; i++) {

var parseResult = parseOmniboxDescription(