chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js - Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/experimental.declarative_custom_bindings.js ('k') | chrome/renderer/resources/extensions/extension_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js b/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

index d24eff57a506e49358cd5796d0d3382ce54e2b03..52a86596eff73c98335926270d93ab4a99c639a1 100644

--- a/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/experimental.socket_custom_bindings.js

@@ -14,7 +14,7 @@

var apiFunctions = api.apiFunctions;

var sendRequest = api.sendRequest;

- apiFunctions.setHandleRequest("experimental.socket.create", function() {

+ apiFunctions.setHandleRequest('create', function() {

var args = arguments;

if (args.length > 3 && args[3] && args[3].onEvent) {

var id = GetNextSocketEventId();

@@ -32,14 +32,14 @@

var eventHandler = chromeHidden.socket.handlers[event.srcId];

if (eventHandler) {

switch (event.type) {

- case "writeComplete":

- case "connectComplete":

+ case 'writeComplete':

+ case 'connectComplete':

eventHandler({

type: event.type,

resultCode: event.resultCode,

});

break;

- case "dataRead":

+ case 'dataRead':

eventHandler({

type: event.type,

resultCode: event.resultCode,

@@ -47,7 +47,7 @@

});

break;

default:

- console.error("Unexpected SocketEvent, type " + event.type);

+ console.error('Unexpected SocketEvent, type ' + event.type);

break;

}

if (event.isFinalEvent) {