chrome/renderer/resources/extensions/browser_action_custom_bindings.js - Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

Issue 9423049: Make registering custom hooks with schema_generated_bindings.js safer and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/browser_action_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

index 47cb684b25b49a2209942761e272214616f0e8ea..8b791a71465f5af3453a33fe19263c2c3d9f5ebe 100644

--- a/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/browser_action_custom_bindings.js

@@ -12,7 +12,7 @@ GetChromeHidden().registerCustomHook('browserAction', function(bindingsAPI) {

var apiFunctions = bindingsAPI.apiFunctions;

var setIcon = bindingsAPI.setIcon;

- apiFunctions.setHandleRequest('browserAction.setIcon', function(details) {

+ apiFunctions.setHandleRequest('setIcon', function(details) {

setIcon(details, this.name, this.definition.parameters, 'browser action');

});

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_private_custom_bindings.js » ('j') | no next file with comments »