Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9270015: Add Mac gamepad input remapper (Closed)

Created:
8 years, 11 months ago by scottmg
Modified:
8 years, 11 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Add Mac gamepad input remapper. + refactor to share associated code between the linux/mac versions. BUG=110829 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118908

Patch Set 1 #

Patch Set 2 : ps3 controller mapping #

Patch Set 3 : 360 controller mapping #

Patch Set 4 : macally ishockx controller #

Patch Set 5 : remove unused dpad helper #

Total comments: 1

Patch Set 6 : fix linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -77 lines) Patch
A content/browser/gamepad/gamepad_standard_mappings.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
D content/browser/gamepad/gamepad_standard_mappings_linux.h View 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/gamepad/gamepad_standard_mappings_linux.cc View 2 chunks +1 line, -36 lines 0 comments Download
A content/browser/gamepad/gamepad_standard_mappings_mac.mm View 1 2 3 4 1 chunk +122 lines, -0 lines 0 comments Download
M content/browser/gamepad/platform_data_fetcher_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gamepad/platform_data_fetcher_linux.cc View 1 2 3 4 5 1 chunk +2 lines, -8 lines 0 comments Download
M content/browser/gamepad/platform_data_fetcher_mac.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/gamepad/platform_data_fetcher_mac.mm View 1 3 chunks +24 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
8 years, 11 months ago (2012-01-23 18:22:07 UTC) #1
scottmg
Oops, Avi is out. John could you have a look? It's not actually Mac specific, ...
8 years, 11 months ago (2012-01-24 17:24:08 UTC) #2
jam
http://codereview.chromium.org/9270015/diff/6001/content/browser/gamepad/gamepad_standard_mappings_linux.cc File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): http://codereview.chromium.org/9270015/diff/6001/content/browser/gamepad/gamepad_standard_mappings_linux.cc#newcode110 content/browser/gamepad/gamepad_standard_mappings_linux.cc:110: GamepadStandardMappingFunction GetGamepadStandardMappingFunction( this code is now used on mac, ...
8 years, 11 months ago (2012-01-24 18:27:03 UTC) #3
scottmg
On 2012/01/24 18:27:03, John Abd-El-Malek wrote: > http://codereview.chromium.org/9270015/diff/6001/content/browser/gamepad/gamepad_standard_mappings_linux.cc > File content/browser/gamepad/gamepad_standard_mappings_linux.cc (right): > > http://codereview.chromium.org/9270015/diff/6001/content/browser/gamepad/gamepad_standard_mappings_linux.cc#newcode110 ...
8 years, 11 months ago (2012-01-24 18:35:23 UTC) #4
jam
On 2012/01/24 18:35:23, scottmg wrote: > On 2012/01/24 18:27:03, John Abd-El-Malek wrote: > > > ...
8 years, 11 months ago (2012-01-24 18:36:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9270015/6001
8 years, 11 months ago (2012-01-24 19:02:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/9270015/14001
8 years, 11 months ago (2012-01-24 19:39:57 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 21:46:00 UTC) #8 
Change committed as 118908

Powered by Google App Engine
This is Rietveld 408576698