Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 8990001: base::Bind: Convert most of net/http. (Closed)

Created:
9 years ago by James Hawkins
Modified:
9 years ago
Reviewers:
csilv, awong
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert most of net/http. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115220

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Test fixes. #

Patch Set 4 : Clang. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1519 lines, -1469 lines) Patch
M net/http/http_auth_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_controller.h View 2 chunks +2 lines, -3 lines 0 comments Download
M net/http/http_auth_controller.cc View 4 chunks +16 lines, -18 lines 0 comments Download
M net/http/http_auth_controller_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M net/http/http_auth_handler.h View 5 chunks +8 lines, -9 lines 0 comments Download
M net/http/http_auth_handler.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M net/http/http_auth_handler_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_basic.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_basic_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_digest.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_digest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_mock.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 5 chunks +21 lines, -20 lines 0 comments Download
M net/http/http_auth_handler_negotiate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M net/http/http_auth_handler_negotiate_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_basic_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_basic_stream.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M net/http/http_cache.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M net/http/http_cache_transaction.h View 3 chunks +10 lines, -9 lines 0 comments Download
M net/http/http_cache_transaction.cc View 16 chunks +31 lines, -31 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 53 chunks +92 lines, -81 lines 0 comments Download
M net/http/http_network_layer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.h View 2 chunks +9 lines, -8 lines 0 comments Download
M net/http/http_network_transaction.cc View 17 chunks +27 lines, -26 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 166 chunks +356 lines, -332 lines 0 comments Download
M net/http/http_pipelined_connection_impl.h View 1 2 7 chunks +9 lines, -10 lines 0 comments Download
M net/http/http_pipelined_connection_impl.cc View 1 2 13 chunks +34 lines, -47 lines 0 comments Download
M net/http/http_pipelined_connection_impl_unittest.cc View 39 chunks +187 lines, -152 lines 0 comments Download
M net/http/http_pipelined_network_transaction_unittest.cc View 12 chunks +63 lines, -57 lines 0 comments Download
M net/http/http_pipelined_stream.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_pipelined_stream.cc View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M net/http/http_proxy_client_socket.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 8 chunks +15 lines, -12 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M net/http/http_response_body_drainer.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_response_body_drainer.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 8 chunks +16 lines, -20 lines 0 comments Download
M net/http/http_stream.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_parser.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/http/http_stream_parser.cc View 7 chunks +16 lines, -17 lines 0 comments Download
M net/http/http_transaction.h View 5 chunks +10 lines, -10 lines 0 comments Download
M net/http/http_transaction_unittest.h View 2 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_transaction_unittest.cc View 8 chunks +23 lines, -21 lines 0 comments Download
M net/http/partial_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/partial_data.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M net/proxy/proxy_resolver_v8.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/client_socket_handle.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base.h View 1 2 3 12 chunks +16 lines, -14 lines 0 comments Download
M net/socket/client_socket_pool_base.cc View 1 2 3 9 chunks +16 lines, -15 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 4 chunks +4 lines, -9 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 3 chunks +10 lines, -26 lines 2 comments Download
M net/socket/socks_client_socket_pool.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/transport_client_socket_pool.h View 1 chunk +2 lines, -17 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket_stream/socket_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream.h View 3 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_http_stream.cc View 13 chunks +23 lines, -23 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 60 chunks +189 lines, -175 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 6 chunks +18 lines, -11 lines 0 comments Download
M net/spdy/spdy_session.h View 1 2 3 4 chunks +14 lines, -8 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 chunks +8 lines, -4 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 13 chunks +43 lines, -42 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_websocket_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_websocket_stream.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 6 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Hawkins
9 years ago (2011-12-18 17:15:08 UTC) #1
James Hawkins
Try job failures are flakes.
9 years ago (2011-12-20 02:35:11 UTC) #2
James Hawkins
+ajwong
9 years ago (2011-12-20 05:34:16 UTC) #3
awong
http://codereview.chromium.org/8990001/diff/12011/net/socket/socket_test_util.cc File net/socket/socket_test_util.cc (left): http://codereview.chromium.org/8990001/diff/12011/net/socket/socket_test_util.cc#oldcode342 net/socket/socket_test_util.cc:342: if (!callback_.is_null()) Are we sure we are supposed to ...
9 years ago (2011-12-20 21:51:35 UTC) #4
James Hawkins
http://codereview.chromium.org/8990001/diff/12011/net/socket/socket_test_util.cc File net/socket/socket_test_util.cc (left): http://codereview.chromium.org/8990001/diff/12011/net/socket/socket_test_util.cc#oldcode342 net/socket/socket_test_util.cc:342: if (!callback_.is_null()) On 2011/12/20 21:51:35, awong wrote: > Are ...
9 years ago (2011-12-20 22:50:48 UTC) #5
awong
9 years ago (2011-12-20 23:06:22 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698