Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: net/http/http_transaction_unittest.cc

Issue 8990001: base::Bind: Convert most of net/http. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_transaction_unittest.cc
diff --git a/net/http/http_transaction_unittest.cc b/net/http/http_transaction_unittest.cc
index ff86bc1109b34ab733cd49a9d926ce398ee77c01..5e145216b0b5ce793bb9650d01fef3d47ecb8b3b 100644
--- a/net/http/http_transaction_unittest.cc
+++ b/net/http/http_transaction_unittest.cc
@@ -161,7 +161,8 @@ TestTransactionConsumer::~TestTransactionConsumer() {
void TestTransactionConsumer::Start(const net::HttpRequestInfo* request,
const net::BoundNetLog& net_log) {
state_ = STARTING;
- int result = trans_->Start(request, this, net_log);
+ int result = trans_->Start(
+ request, base::Bind(&net::OldCompletionCallbackAdapter, this), net_log);
if (result != net::ERR_IO_PENDING)
DidStart(result);
}
@@ -193,7 +194,8 @@ void TestTransactionConsumer::DidFinish(int result) {
void TestTransactionConsumer::Read() {
state_ = READING;
read_buf_ = new net::IOBuffer(1024);
- int result = trans_->Read(read_buf_, 1024, this);
+ int result = trans_->Read(
+ read_buf_, 1024, base::Bind(&net::OldCompletionCallbackAdapter, this));
if (result != net::ERR_IO_PENDING)
DidRead(result);
}
@@ -214,7 +216,7 @@ void TestTransactionConsumer::RunWithParams(const Tuple1<int>& params) {
MockNetworkTransaction::MockNetworkTransaction(MockNetworkLayer* factory)
- : ALLOW_THIS_IN_INITIALIZER_LIST(ptr_factory_(this)),
+ : ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
data_cursor_(0),
transaction_factory_(factory->AsWeakPtr()) {
}
@@ -222,7 +224,7 @@ MockNetworkTransaction::MockNetworkTransaction(MockNetworkLayer* factory)
MockNetworkTransaction::~MockNetworkTransaction() {}
int MockNetworkTransaction::Start(const net::HttpRequestInfo* request,
- net::OldCompletionCallback* callback,
+ const net::CompletionCallback& callback,
const net::BoundNetLog& net_log) {
const MockTransaction* t = FindMockTransaction(request->url);
if (!t)
@@ -261,19 +263,19 @@ int MockNetworkTransaction::Start(const net::HttpRequestInfo* request,
}
int MockNetworkTransaction::RestartIgnoringLastError(
- net::OldCompletionCallback* callback) {
+ const net::CompletionCallback& callback) {
return net::ERR_FAILED;
}
int MockNetworkTransaction::RestartWithCertificate(
net::X509Certificate* client_cert,
- net::OldCompletionCallback* callback) {
+ const net::CompletionCallback& callback) {
return net::ERR_FAILED;
}
int MockNetworkTransaction::RestartWithAuth(
const net::AuthCredentials& credentials,
- net::OldCompletionCallback* callback) {
+ const net::CompletionCallback& callback) {
return net::ERR_FAILED;
}
@@ -282,7 +284,7 @@ bool MockNetworkTransaction::IsReadyToRestartForAuth() {
}
int MockNetworkTransaction::Read(net::IOBuffer* buf, int buf_len,
- net::OldCompletionCallback* callback) {
+ const net::CompletionCallback& callback) {
int data_len = static_cast<int>(data_.size());
int num = std::min(buf_len, data_len - data_cursor_);
if (num) {
@@ -317,16 +319,16 @@ uint64 MockNetworkTransaction::GetUploadProgress() const {
return 0;
}
-void MockNetworkTransaction::CallbackLater(net::OldCompletionCallback* callback,
- int result) {
- MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
- &MockNetworkTransaction::RunCallback, ptr_factory_.GetWeakPtr(),
- callback, result));
+void MockNetworkTransaction::CallbackLater(
+ const net::CompletionCallback& callback, int result) {
+ MessageLoop::current()->PostTask(
+ FROM_HERE, base::Bind(&MockNetworkTransaction::RunCallback,
+ weak_factory_.GetWeakPtr(), callback, result));
}
-void MockNetworkTransaction::RunCallback(net::OldCompletionCallback* callback,
- int result) {
- callback->Run(result);
+void MockNetworkTransaction::RunCallback(
+ const net::CompletionCallback& callback, int result) {
+ callback.Run(result);
}
MockNetworkLayer::MockNetworkLayer()
@@ -359,19 +361,19 @@ net::HttpNetworkSession* MockNetworkLayer::GetSession() {
int ReadTransaction(net::HttpTransaction* trans, std::string* result) {
int rv;
- TestOldCompletionCallback callback;
+ net::TestCompletionCallback callback;
std::string content;
do {
scoped_refptr<net::IOBuffer> buf(new net::IOBuffer(256));
- rv = trans->Read(buf, 256, &callback);
+ rv = trans->Read(buf, 256, callback.callback());
if (rv == net::ERR_IO_PENDING)
rv = callback.WaitForResult();
- if (rv > 0) {
+
+ if (rv > 0)
content.append(buf->data(), rv);
- } else if (rv < 0) {
+ else if (rv < 0)
return rv;
- }
} while (rv > 0);
result->swap(content);

Powered by Google App Engine
This is Rietveld 408576698