Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2484)

Unified Diff: net/http/http_proxy_client_socket_pool.h

Issue 8990001: base::Bind: Convert most of net/http. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_proxy_client_socket_pool.h
diff --git a/net/http/http_proxy_client_socket_pool.h b/net/http/http_proxy_client_socket_pool.h
index 68a466b7bda88be7624bbe5817574cdd72c7db37..09da943d1e943967757b70178e08901e45f86600 100644
--- a/net/http/http_proxy_client_socket_pool.h
+++ b/net/http/http_proxy_client_socket_pool.h
@@ -156,7 +156,6 @@ class HttpProxyConnectJob : public ConnectJob {
State next_state_;
CompletionCallback callback_;
- OldCompletionCallbackImpl<HttpProxyConnectJob> callback_old_;
scoped_ptr<ClientSocketHandle> transport_socket_handle_;
scoped_ptr<ProxyClientSocket> transport_socket_;
bool using_spdy_;
@@ -169,7 +168,8 @@ class HttpProxyConnectJob : public ConnectJob {
};
class NET_EXPORT_PRIVATE HttpProxyClientSocketPool
- : public ClientSocketPool, public LayeredPool {
+ : public ClientSocketPool,
+ public LayeredPool {
public:
HttpProxyClientSocketPool(
int max_sockets,
@@ -182,12 +182,12 @@ class NET_EXPORT_PRIVATE HttpProxyClientSocketPool
virtual ~HttpProxyClientSocketPool();
- // ClientSocketPool methods:
+ // ClientSocketPool implementation.
virtual int RequestSocket(const std::string& group_name,
const void* connect_params,
RequestPriority priority,
ClientSocketHandle* handle,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
const BoundNetLog& net_log) OVERRIDE;
virtual void RequestSockets(const std::string& group_name,
@@ -230,7 +230,7 @@ class NET_EXPORT_PRIVATE HttpProxyClientSocketPool
virtual ClientSocketPoolHistograms* histograms() const OVERRIDE;
- // LayeredPool methods:
+ // LayeredPool implementation.
virtual bool CloseOneIdleConnection() OVERRIDE;
private:

Powered by Google App Engine
This is Rietveld 408576698