Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: net/http/http_auth_handler.h

Issue 8990001: base::Bind: Convert most of net/http. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clang. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_auth_handler.h
diff --git a/net/http/http_auth_handler.h b/net/http/http_auth_handler.h
index cdda9447da80240891136f4817ec4fd2540b080a..864a5129e469c21553524fa85b05ed64d3acf995 100644
--- a/net/http/http_auth_handler.h
+++ b/net/http/http_auth_handler.h
@@ -27,7 +27,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandler {
// Initializes the handler using a challenge issued by a server.
// |challenge| must be non-NULL and have already tokenized the
- // authentication scheme, but none of the tokens occuring after the
+ // authentication scheme, but none of the tokens occurring after the
// authentication scheme. |target| and |origin| are both stored
// for later use, and are not part of the initial challenge.
bool InitFromChallenge(HttpAuth::ChallengeTokenizer* challenge,
@@ -46,7 +46,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandler {
// be made with a different nonce provided in the challenge.
//
// |challenge| must be non-NULL and have already tokenized the
- // authentication scheme, but none of the tokens occuring after the
+ // authentication scheme, but none of the tokens occurring after the
// authentication scheme.
virtual HttpAuth::AuthorizationResult HandleAnotherChallenge(
HttpAuth::ChallengeTokenizer* challenge) = 0;
@@ -73,7 +73,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandler {
// token, and the value of |*auth_token| is unspecified.
int GenerateAuthToken(const AuthCredentials* credentials,
const HttpRequestInfo* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
std::string* auth_token);
// The authentication scheme as an enumerated value.
@@ -148,18 +148,18 @@ class NET_EXPORT_PRIVATE HttpAuthHandler {
// Initializes the handler using a challenge issued by a server.
// |challenge| must be non-NULL and have already tokenized the
- // authentication scheme, but none of the tokens occuring after the
+ // authentication scheme, but none of the tokens occurring after the
// authentication scheme.
- // Implementations are expcted to initialize the following members:
+ // Implementations are expected to initialize the following members:
// scheme_, realm_, score_, properties_
virtual bool Init(HttpAuth::ChallengeTokenizer* challenge) = 0;
// |GenerateAuthTokenImpl()} is the auth-scheme specific implementation
- // of generating the next auth token. Callers sohuld use |GenerateAuthToken()|
+ // of generating the next auth token. Callers should use |GenerateAuthToken()|
// which will in turn call |GenerateAuthTokenImpl()|
virtual int GenerateAuthTokenImpl(const AuthCredentials* credentials,
const HttpRequestInfo* request,
- OldCompletionCallback* callback,
+ const CompletionCallback& callback,
std::string* auth_token) = 0;
// The auth-scheme as an enumerated value.
@@ -191,8 +191,7 @@ class NET_EXPORT_PRIVATE HttpAuthHandler {
void OnGenerateAuthTokenComplete(int rv);
void FinishGenerateAuthToken();
- OldCompletionCallback* original_callback_;
- OldCompletionCallbackImpl<HttpAuthHandler> wrapper_callback_;
+ CompletionCallback callback_;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698