net/http/http_auth_handler_basic.cc - Issue 8990001: base::Bind: Convert most of net/http.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_basic.cc

Issue 8990001: base::Bind: Convert most of net/http. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clang. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_basic.cc

diff --git a/net/http/http_auth_handler_basic.cc b/net/http/http_auth_handler_basic.cc

index df24d0e89656c4df8b2a25f5e5430fdc414f91e2..52396cc6b6c55939469851cd8f3099b0dd70ef5c 100644

--- a/net/http/http_auth_handler_basic.cc

+++ b/net/http/http_auth_handler_basic.cc

@@ -86,10 +86,8 @@ HttpAuth::AuthorizationResult HttpAuthHandlerBasic::HandleAnotherChallenge(

}

int HttpAuthHandlerBasic::GenerateAuthTokenImpl(

- const AuthCredentials* credentials,

- const HttpRequestInfo*,

- OldCompletionCallback*,

- std::string* auth_token) {

+ const AuthCredentials* credentials, const HttpRequestInfo*,

+ const CompletionCallback&, std::string* auth_token) {

DCHECK(credentials);

// TODO(eroman): is this the right encoding of username/password?

std::string base64_username_password;