Convert WebContents to return a content::NavigationController instead of the implementation. Upda...

Convert WebContents to return a content::NavigationController instead of the implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere.

BUG=98716
TBR=joi
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116244

[Jói, 2012-01-04 11:06:32]

still LGTM, see suggestion for follow-up below

http://codereview.chromium.org/8983010/diff/8001/content/browser/tab_contents...
File content/browser/tab_contents/navigation_controller.cc (right):

http://codereview.chromium.org/8983010/diff/8001/content/browser/tab_contents...
content/browser/tab_contents/navigation_controller.cc:158: void
NavigationController::DisablePromptOnRepost() {
Possible follow-up:  Should this be DisablePromptOnRepostForTesting ?

[Jói, 2012-01-04 11:07:04]

LGTM

On Tue, Jan 3, 2012 at 11:41 PM, <jam@chromium.org> wrote:

> Reviewers: Jói,
>
> Description:
> Convert WebContents to return a content::NavigationController instead of
> the
> implementation. Update all the headers in chrome to use the interface
> only. In a
> subsequent cl, I'll rename the implementation to NavigationControllerImpl
> and
> also get rid of content::NavigationController everywhere.
>
> BUG=98716
> TBR=joi
>
> Please review this at
http://codereview.chromium.**org/8983010/<http://codereview.chromium.org/8983...
>
> SVN Base: svn://chrome-svn/chrome/trunk/**src/
>
> Affected files:
>  M     chrome/browser/DEPS
>  M     chrome/browser/alternate_nav_**url_fetcher.cc
>  M     chrome/browser/autofill/**autofill_browsertest.cc
>  M     chrome/browser/autofill/**autofill_feedback_infobar_**delegate.cc
>  M     chrome/browser/automation/**automation_provider_observers.**cc
>  M     chrome/browser/automation/**automation_provider_win.cc
>  M     chrome/browser/automation/**automation_tab_tracker.cc
>  M     chrome/browser/automation/**testing_automation_provider.cc
>  M     chrome/browser/browser_**commands_unittest.cc
>  M     chrome/browser/chromeos/boot_**times_loader.cc
>  M     chrome/browser/content_**settings/tab_specific_content_**
> settings.cc
>  M     chrome/browser/debugger/**devtools_window.cc
>  M     chrome/browser/download/**download_request_limiter.h
>  M     chrome/browser/download/**download_request_limiter.cc
>  M     chrome/browser/download/**download_request_limiter_**unittest.cc
>  M     chrome/browser/extensions/**extension_browser_event_**router.cc
>  M     chrome/browser/extensions/**extension_crash_recovery_**
> browsertest.cc
>  M     chrome/browser/extensions/**extension_navigation_observer.**cc
>  M     chrome/browser/extensions/**extension_tabs_module.cc
>  M     chrome/browser/extensions/**extension_url_rewrite_**browsertest.cc
>  M     chrome/browser/extensions/**extension_web_ui.cc
>  M     chrome/browser/extensions/**webstore_installer.h
>  M     chrome/browser/extensions/**webstore_installer.cc
>  M     chrome/browser/external_tab_**container_win.cc
>  M     chrome/browser/favicon/**favicon_tab_helper.cc
>  M     chrome/browser/geolocation/**geolocation_browsertest.cc
>  M     chrome/browser/google/google_**url_tracker.cc
>  M     chrome/browser/history/top_**sites.cc
>  M     chrome/browser/infobars/**infobar_delegate.cc
>  M     chrome/browser/infobars/**infobar_tab_helper.cc
>  M     chrome/browser/instant/**instant_browsertest.cc
>  M     chrome/browser/instant/**instant_loader.cc
>  M     chrome/browser/notifications/**balloon_host.cc
>  M     chrome/browser/prerender/**prerender_manager.cc
>  M     chrome/browser/printing/print_**dialog_cloud.cc
>  M     chrome/browser/printing/print_**preview_tab_controller.cc
>  M     chrome/browser/repost_form_**warning_controller.h
>  M     chrome/browser/repost_form_**warning_controller.cc
>  M     chrome/browser/safe_browsing/**browser_feature_extractor.cc
>  M     chrome/browser/safe_browsing/**client_side_detection_host.cc
>  M     chrome/browser/safe_browsing/**malware_details.cc
>  M     chrome/browser/safe_browsing/**safe_browsing_blocking_page.cc
>  M     chrome/browser/safe_browsing/**safe_browsing_blocking_page_**
> test.cc
>  M     chrome/browser/sessions/**session_restore.cc
>  M     chrome/browser/sessions/**session_types.cc
>  M     chrome/browser/sessions/tab_**restore_service.h
>  M     chrome/browser/sessions/tab_**restore_service.cc
>  M     chrome/browser/sessions/tab_**restore_service_browsertest.cc
>  M     chrome/browser/sessions/tab_**restore_service_delegate.h
>  M     chrome/browser/sidebar/**sidebar_container.cc
>  M     chrome/browser/ssl/ssl_**blocking_page.cc
>  M     chrome/browser/ssl/ssl_**browser_tests.cc
>  M     chrome/browser/sync/glue/**session_change_processor.cc
>  M     chrome/browser/tab_contents/**language_state.h
>  M     chrome/browser/tab_contents/**language_state.cc
>  M     chrome/browser/tabs/tab_strip_**model.h
>  M     chrome/browser/tabs/tab_strip_**model.cc
>  M     chrome/browser/tabs/tab_strip_**model_order_controller.cc
>  M     chrome/browser/tabs/tab_strip_**model_unittest.cc
>  M     chrome/browser/translate/**options_menu_model.cc
>  M     chrome/browser/translate/**translate_manager.cc
>  M     chrome/browser/ui/auto_login_**prompter.cc
>  M     chrome/browser/ui/blocked_**content/blocked_content_tab_**helper.cc
>  M     chrome/browser/ui/bookmarks/**bookmark_tab_helper.cc
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_tab_**restore_service_delegate.cc
>  M     chrome/browser/ui/cocoa/**applescript/tab_applescript.mm
>  M    
chrome/browser/ui/cocoa/tab_**contents/tab_contents_**controller.mm<http://tab_contents_controller.mm>
>  M    
chrome/browser/ui/cocoa/tabs/t**ab_strip_controller.mm<http://tab_strip_controller.mm>
>  M     chrome/browser/ui/intents/web_**intent_picker_controller.cc
>  M     chrome/browser/ui/login/login_**prompt.cc
>  M     chrome/browser/ui/login/login_**prompt_browsertest.cc
>  M     chrome/browser/ui/pdf/pdf_**browsertest.cc
>  M     chrome/browser/ui/search_**engines/search_engine_tab_**helper.cc
>  M     chrome/browser/ui/sync/tab_**contents_wrapper_synced_tab_**
> delegate.cc
>  M     chrome/browser/ui/tab_modal_**confirm_dialog_delegate.cc
>  M     chrome/browser/ui/toolbar/**back_forward_menu_model.cc
>  M     chrome/browser/ui/toolbar/**back_forward_menu_model_**unittest.cc
>  M     chrome/browser/ui/toolbar/**toolbar_model.h
>  M     chrome/browser/ui/toolbar/**toolbar_model.cc
>  M     chrome/browser/ui/views/**location_bar/click_handler.cc
>  M     chrome/browser/ui/views/sad_**tab_view.cc
>  M     chrome/browser/ui/webui/**active_downloads_ui.cc
>  M     chrome/browser/ui/webui/bug_**report_ui.cc
>  M     chrome/browser/ui/webui/cloud_**print_signin_dialog.cc
>  M     chrome/browser/ui/webui/**options/chromeos/cros_**
> language_options_handler.cc
>  M     chrome/browser/ui/webui/**options2/chromeos/cros_**
> language_options_handler2.cc
>  M     chrome/browser/ui/webui/**options2/personal_options_**handler2.cc
>  M     chrome/browser/ui/webui/print_**preview_handler.cc
>  M     chrome/browser/ui/webui/sync_**promo/sync_promo_handler.cc
>  M     chrome/browser/ui/webui/web_**ui_browsertest.cc
>  M     chrome/browser/ui/webui/web_**ui_unittest.cc
>  M     chrome/test/base/browser_with_**test_window_test.h
>  M     chrome/test/base/browser_with_**test_window_test.cc
>  M     chrome/test/base/test_html_**dialog_observer.cc
>  M     chrome/test/base/ui_test_**utils.cc
>  M     content/browser/renderer_host/**test_render_view_host.h
>  M     content/browser/renderer_host/**test_render_view_host.cc
>  M     content/browser/tab_contents/**interstitial_page.cc
>  M     content/browser/tab_contents/**navigation_controller.h
>  M     content/browser/tab_contents/**navigation_controller.cc
>  M     content/browser/tab_contents/**navigation_controller_**unittest.cc
>  M     content/browser/tab_contents/**tab_contents.h
>  M     content/browser/tab_contents/**tab_contents.cc
>  M     content/browser/tab_contents/**tab_contents_unittest.cc
>  M     content/browser/tab_contents/**test_tab_contents.cc
>  M     content/public/browser/**navigation_controller.h
>  M     content/public/browser/web_**contents.h
>
>
>