chrome/test/base/browser_with_test_window_test.cc - Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/browser_with_test_window_test.cc

Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix mac Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/base/browser_with_test_window_test.h ('k') | chrome/test/base/test_html_dialog_observer.cc » ('j') | content/browser/tab_contents/navigation_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/browser_with_test_window_test.cc

===================================================================

--- chrome/test/base/browser_with_test_window_test.cc (revision 116232)

+++ chrome/test/base/browser_with_test_window_test.cc (working copy)

@@ -13,8 +13,8 @@

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

#include "chrome/common/render_messages.h"

#include "chrome/test/base/testing_profile.h"

-#include "content/browser/tab_contents/navigation_controller.h"

#include "content/browser/tab_contents/render_view_host_manager.h"

+#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/page_transition_types.h"

@@ -72,7 +72,7 @@

}

void BrowserWithTestWindowTest::CommitPendingLoad(

- NavigationController* controller) {

+ content::NavigationController* controller) {

if (!controller->GetPendingEntry())

return; // Nothing to commit.

@@ -115,7 +115,7 @@

}

void BrowserWithTestWindowTest::NavigateAndCommit(

- NavigationController* controller,

+ content::NavigationController* controller,

const GURL& url) {

controller->LoadURL(

url, content::Referrer(), content::PAGE_TRANSITION_LINK, std::string());