chrome/browser/ui/login/login_prompt.cc - Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix mac Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/login/login_prompt_browsertest.cc » ('j') | content/browser/tab_contents/navigation_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/login/login_prompt.cc

===================================================================

--- chrome/browser/ui/login/login_prompt.cc (revision 116232)

+++ chrome/browser/ui/login/login_prompt.cc (working copy)

@@ -278,7 +278,7 @@

content::NotificationService* service =

content::NotificationService::current();

- NavigationController* controller = NULL;

+ content::NavigationController* controller = NULL;

TabContents* requesting_contents = GetTabContentsForLogin();

if (requesting_contents)

@@ -297,7 +297,7 @@

content::NotificationService* service =

content::NotificationService::current();

- NavigationController* controller = NULL;

+ content::NavigationController* controller = NULL;

TabContents* requesting_contents = GetTabContentsForLogin();

if (requesting_contents)

@@ -321,7 +321,8 @@

content::NotificationService* service =

content::NotificationService::current();

- NavigationController* controller = &requesting_contents->GetController();

+ content::NavigationController* controller =

+ &requesting_contents->GetController();

AuthSuppliedLoginNotificationDetails details(this, username, password);

service->Notify(