Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/toolbar/toolbar_model.cc

Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix mac Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_model.cc
===================================================================
--- chrome/browser/ui/toolbar/toolbar_model.cc (revision 116232)
+++ chrome/browser/ui/toolbar/toolbar_model.cc (working copy)
@@ -15,9 +15,9 @@
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "content/browser/cert_store.h"
-#include "content/browser/tab_contents/navigation_controller.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "content/browser/webui/web_ui.h"
+#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/ssl_status.h"
#include "content/public/common/content_constants.h"
@@ -44,7 +44,8 @@
GURL url(chrome::kAboutBlankURL);
std::string languages; // Empty if we don't have a |navigation_controller|.
- NavigationController* navigation_controller = GetNavigationController();
+ content::NavigationController* navigation_controller =
+ GetNavigationController();
if (navigation_controller) {
Profile* profile =
Profile::FromBrowserContext(navigation_controller->GetBrowserContext());
@@ -74,7 +75,8 @@
// - The view-source test must come before the WebUI test because of the case
// of view-source:chrome://newtab, which should display its URL despite what
// chrome://newtab's WebUI says.
- NavigationController* controller = GetNavigationController();
+ content::NavigationController* controller =
+ GetNavigationController();
NavigationEntry* entry = controller ? controller->GetVisibleEntry() : NULL;
if (entry) {
if (entry->IsViewSourceMode() ||
@@ -97,7 +99,8 @@
if (input_in_progress_) // When editing, assume no security style.
return NONE;
- NavigationController* navigation_controller = GetNavigationController();
+ content::NavigationController* navigation_controller =
+ GetNavigationController();
if (!navigation_controller) // We might not have a controller on init.
return NONE;
@@ -169,7 +172,7 @@
UTF8ToUTF16(cert.subject().country_name));
}
-NavigationController* ToolbarModel::GetNavigationController() const {
+content::NavigationController* ToolbarModel::GetNavigationController() const {
// This |current_tab| can be NULL during the initialization of the
// toolbar during window creation (i.e. before any tabs have been added
// to the window).

Powered by Google App Engine
This is Rietveld 408576698