Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: content/browser/tab_contents/navigation_controller_unittest.cc

Issue 8983010: Convert WebContents to return a content::NavigationController instead of the implementation. Upda... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix mac Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/navigation_controller_unittest.cc
===================================================================
--- content/browser/tab_contents/navigation_controller_unittest.cc (revision 116232)
+++ content/browser/tab_contents/navigation_controller_unittest.cc (working copy)
@@ -1491,7 +1491,7 @@
entries.push_back(entry);
TabContents our_contents(
browser_context(), NULL, MSG_ROUTING_NONE, NULL, NULL);
- NavigationController& our_controller = our_contents.GetController();
+ NavigationController& our_controller = our_contents.GetControllerImpl();
our_controller.Restore(0, true, &entries);
ASSERT_EQ(0u, entries.size());
@@ -1558,7 +1558,7 @@
entries.push_back(entry);
TabContents our_contents(
browser_context(), NULL, MSG_ROUTING_NONE, NULL, NULL);
- NavigationController& our_controller = our_contents.GetController();
+ NavigationController& our_controller = our_contents.GetControllerImpl();
our_controller.Restore(0, true, &entries);
ASSERT_EQ(0u, entries.size());
@@ -2012,7 +2012,7 @@
NavigateAndCommit(url2);
scoped_ptr<TestTabContents> other_contents(CreateTestTabContents());
- NavigationController& other_controller = other_contents->GetController();
+ NavigationController& other_controller = other_contents->GetControllerImpl();
other_contents->NavigateAndCommit(url3);
other_contents->ExpectSetHistoryLengthAndPrune(
NavigationEntryImpl::FromNavigationEntry(
@@ -2043,7 +2043,7 @@
controller().GoBack();
scoped_ptr<TestTabContents> other_contents(CreateTestTabContents());
- NavigationController& other_controller = other_contents->GetController();
+ NavigationController& other_controller = other_contents->GetControllerImpl();
other_contents->ExpectSetHistoryLengthAndPrune(NULL, 1, -1);
other_controller.CopyStateFromAndPrune(&controller());
@@ -2068,7 +2068,7 @@
controller().GoBack();
scoped_ptr<TestTabContents> other_contents(CreateTestTabContents());
- NavigationController& other_controller = other_contents->GetController();
+ NavigationController& other_controller = other_contents->GetControllerImpl();
other_controller.LoadURL(
url3, content::Referrer(), content::PAGE_TRANSITION_TYPED, std::string());
other_contents->ExpectSetHistoryLengthAndPrune(NULL, 1, -1);

Powered by Google App Engine
This is Rietveld 408576698