Issue 8885022: Move URLPattern::ParseOption into a field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed)

Created:
9 years ago by Aaron Boodman

Modified:
9 years ago

Reviewers:
jstritar

CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move URLPattern::ParseOption into a field. This will be needed to change the default of URLPattern to USE_PORTS. BUG=104104 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113730

Patch Set 1 #

Patch Set 2 : more minor sprucing #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -194 lines)			Patch
M	chrome/browser/extensions/crx_installer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_content_settings_helpers.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/extension_context_menu_api.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_permissions_api.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_webrequest_api.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/user_script_master.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_installer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu_unittest.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.cc	View		14 chunks	+25 lines, -27 lines	0 comments	Download
M	chrome/common/extensions/extension_messages.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/url_pattern.h	View	1	3 chunks	+12 lines, -17 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.cc	View	1	4 chunks	+17 lines, -11 lines	0 comments	Download
M	chrome/common/extensions/url_pattern_unittest.cc	View		23 chunks	+61 lines, -84 lines	0 comments	Download
M	chrome/common/extensions/user_script.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/user_script_unittest.cc	View		6 chunks	+16 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages