Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: chrome/browser/extensions/extension_context_menu_api.cc

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more minor sprucing Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_api.cc
diff --git a/chrome/browser/extensions/extension_context_menu_api.cc b/chrome/browser/extensions/extension_context_menu_api.cc
index db91c4d54129e5bef620aefb1834abd5e6859f49..2cb03923dc966a7ac94909c6c6bf2ac6e03bd868 100644
--- a/chrome/browser/extensions/extension_context_menu_api.cc
+++ b/chrome/browser/extensions/extension_context_menu_api.cc
@@ -139,11 +139,10 @@ bool ExtensionContextMenuFunction::ParseURLPatterns(
if (!(*i)->GetAsString(&tmp))
return false;
- URLPattern pattern(URLPattern::SCHEME_ALL);
+ URLPattern pattern(URLPattern::IGNORE_PORTS, URLPattern::SCHEME_ALL);
// TODO(skerner): Consider enabling strict pattern parsing
// if this extension's location indicates that it is under development.
- if (URLPattern::PARSE_SUCCESS != pattern.Parse(tmp,
- URLPattern::IGNORE_PORTS)) {
+ if (URLPattern::PARSE_SUCCESS != pattern.Parse(tmp)) {
error_ = ExtensionErrorUtils::FormatErrorMessage(kInvalidURLPatternError,
tmp);
return false;

Powered by Google App Engine
This is Rietveld 408576698