Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/extensions/extension_content_settings_helpers.cc

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more minor sprucing Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_context_menu_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_content_settings_helpers.cc
diff --git a/chrome/browser/extensions/extension_content_settings_helpers.cc b/chrome/browser/extensions/extension_content_settings_helpers.cc
index 580983240f2e1a6da3beb7a89bd4fdde146c3bd6..25d9c626ed76c29aba2220121ed599871da2776f 100644
--- a/chrome/browser/extensions/extension_content_settings_helpers.cc
+++ b/chrome/browser/extensions/extension_content_settings_helpers.cc
@@ -57,11 +57,11 @@ namespace extension_content_settings_helpers {
ContentSettingsPattern ParseExtensionPattern(const std::string& pattern_str,
std::string* error) {
- URLPattern url_pattern(URLPattern::SCHEME_HTTP |
- URLPattern::SCHEME_HTTPS |
- URLPattern::SCHEME_FILE);
- URLPattern::ParseResult result =
- url_pattern.Parse(pattern_str, URLPattern::USE_PORTS);
+ const int kAllowedSchemes =
+ URLPattern::SCHEME_HTTP | URLPattern::SCHEME_HTTPS |
+ URLPattern::SCHEME_FILE;
+ URLPattern url_pattern(URLPattern::USE_PORTS, kAllowedSchemes);
+ URLPattern::ParseResult result = url_pattern.Parse(pattern_str);
if (result != URLPattern::PARSE_SUCCESS) {
*error = URLPattern::GetParseResultString(result);
return ContentSettingsPattern();
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_context_menu_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698