chrome/browser/tab_contents/render_view_context_menu_unittest.cc - Issue 8885022: Move URLPattern::ParseOption into a field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu_unittest.cc

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor sprucing Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/render_view_context_menu_unittest.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu_unittest.cc b/chrome/browser/tab_contents/render_view_context_menu_unittest.cc

index 558935492e6b15e06cc22dc9da488b7ced005fc7..338f29b7cb390c3d470e89358606c09a5d8ca950 100644

--- a/chrome/browser/tab_contents/render_view_context_menu_unittest.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu_unittest.cc

@@ -72,8 +72,8 @@ static ContextMenuParams CreateParams(int contexts) {

// Generates a URLPatternSet with a single pattern

static URLPatternSet CreatePatternSet(const std::string& pattern) {

- URLPattern target(URLPattern::SCHEME_HTTP);

- target.Parse(pattern, URLPattern::IGNORE_PORTS);

+ URLPattern target(URLPattern::IGNORE_PORTS, URLPattern::SCHEME_HTTP);

+ target.Parse(pattern);

URLPatternSet rv;

rv.AddPattern(target);

@@ -237,4 +237,3 @@ TEST_F(RenderViewContextMenuTest, TargetIgnoredForSelectionOnImage) {

EXPECT_TRUE(ExtensionContextAndPatternMatch(params, contexts, patterns));

}