chrome/browser/extensions/extension_prefs.cc - Issue 8885022: Move URLPattern::ParseOption into a field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs.cc

Issue 8885022: Move URLPattern::ParseOption into a field. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more minor sprucing Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_prefs.cc

diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc

index 875b84224c7a54b8efdf8ebaa0fb208712903e94..49bc1595eced5e326b9554e448899b8693ae99c6 100644

--- a/chrome/browser/extensions/extension_prefs.cc

+++ b/chrome/browser/extensions/extension_prefs.cc

@@ -432,9 +432,8 @@ bool ExtensionPrefs::ReadExtensionPrefURLPatternSet(

std::string item;

if (!value->GetString(i, &item))

return false;

- URLPattern pattern(valid_schemes);

- if (pattern.Parse(item, URLPattern::IGNORE_PORTS) !=

- URLPattern::PARSE_SUCCESS) {

+ URLPattern pattern(URLPattern::IGNORE_PORTS, valid_schemes);

+ if (pattern.Parse(item) != URLPattern::PARSE_SUCCESS) {

NOTREACHED();

return false;

}