Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 888005: Fix issues with compiling V8 with LLVM Clang... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix issues with compiling V8 with LLVM Clang Added this-> in some places where accessing a method on a templated base class. Added #include <strings.h> for bit_cast, moved it to utils.h and renamed it to BitCast. Patch by Evan Martin <evan@chromium.org>;, see http://codereview.chromium.org/894001 and http://codereview.chromium.org/888003 Committed: http://code.google.com/p/v8/source/detail?r=4111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -69 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/double.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -36 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/top.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/utils.h View 3 chunks +39 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-12 09:45:25 UTC) #1
Kevin Millikin (Chromium)
LGTM.
10 years, 9 months ago (2010-03-12 10:19:20 UTC) #2
Evan Martin
10 years, 9 months ago (2010-03-12 16:41:40 UTC) #3
Awesome, thanks.

FYI I've been slowly building bits of Chrome with Clang and filing bugs on them
where we cause it to crash.  (Clang has almost magically good error messages,
it's pretty amazing; for this two-phase stuff it puts a little arrow pointing to
where the this-> is needed, it handles macros like functions, it detects when
you've made a typo in a name and suggests the corrected name, etc.)

It turns out v8 is a pretty serious C++ test suite due to the complex templates,
so we're not quite there yet, but I think we're close.  :)

Powered by Google App Engine
This is Rietveld 408576698