Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 888003: bit_cast<> uses memcpy(), so globals.h must #include <string.h>. (Closed)

Created:
10 years, 9 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Søren Thygesen Gjesse, sgjesse
CC:
v8-dev
Visibility:
Public.

Description

bit_cast<> uses memcpy(), so globals.h must #include <string.h>.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/globals.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Martin
It's actually not clear to me how this file compiled before -- I think it ...
10 years, 9 months ago (2010-03-11 21:59:06 UTC) #1
Søren Thygesen Gjesse
I think moving bit_cast to utils.h (and renaming it to BitCast ) is the right ...
10 years, 9 months ago (2010-03-12 08:14:35 UTC) #2
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-12 09:45:41 UTC) #3
On 2010/03/12 08:14:35, Søren Gjesse wrote:
> I think moving bit_cast to utils.h (and renaming it to BitCast ) is the right
> solution.
> 
> Where did this cause trouble?

Moved to http://codereview.chromium.org/888005.

Powered by Google App Engine
This is Rietveld 408576698