Issue 888003: bit_cast<> uses memcpy(), so globals.h must #include <string.h>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 888003: bit_cast<> uses memcpy(), so globals.h must #include <string.h>. (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, sgjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

bit_cast<> uses memcpy(), so globals.h must #include <string.h>.

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/globals.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

It's actually not clear to me how this file compiled before -- I think it ...

10 years, 9 months ago (2010-03-11 21:59:06 UTC) #1

Søren Thygesen Gjesse

I think moving bit_cast to utils.h (and renaming it to BitCast ) is the right ...

10 years, 9 months ago (2010-03-12 08:14:35 UTC) #2

Søren Thygesen Gjesse

10 years, 9 months ago (2010-03-12 09:45:41 UTC) #3

On 2010/03/12 08:14:35, Søren Gjesse wrote:
> I think moving bit_cast to utils.h (and renaming it to BitCast ) is the right
> solution.
> 
> Where did this cause trouble?

Moved to http://codereview.chromium.org/888005.

Expand Messages | Collapse Messages