Issue 894001: Use this->foo() in place of foo() in some places to appease pedantic compiler...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 894001: Use this->foo() in place of foo() in some places to appease pedantic compiler... (Closed)

Created:
10 years, 9 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, sgjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Use this->foo() in place of foo() in some places to appease pedantic compilers. Gory details are here: http://blog.llvm.org/2009/12/dreaded-two-phase-name-lookup.html

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/objects.h	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM - I will land this for you BTW in which environment did this cause ...

10 years, 9 months ago (2010-03-12 08:07:53 UTC) #2

Søren Thygesen Gjesse

10 years, 9 months ago (2010-03-12 09:46:02 UTC) #3

On 2010/03/12 08:07:53, Søren Gjesse wrote:
> LGTM - I will land this for you
> 
> BTW in which environment did this cause compiler warnings?

Moved to http://codereview.chromium.org/888005.

Expand Messages | Collapse Messages