Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8833004: Remove BubbleDelegateView ctor color arg, add simple setter/getter. (Closed)

Created:
9 years ago by msw
Modified:
9 years ago
Reviewers:
stevenjb, alicet1, DaveMoore, sky
CC:
chromium-reviews, jstritar+watch_chromium.org, msw+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, tfarina, alicet1, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove BubbleDelegateView ctor color arg, add simple setter/getter. Call browser::CreateBubbleView instead of BubbleDelegateView::CreateBubble for ExtensionInstalledBubble and AvatarMenuBubbleView. BUG=105023 TEST=No visible bubble changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113523

Patch Set 1 : Update call to GetColor. #

Total comments: 3

Patch Set 2 : Pass set_color SkColor arg by value. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -67 lines) Patch
M chrome/browser/chromeos/login/message_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/setting_level_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_bubble.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/speech/speech_input_bubble_views.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/confirm_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/global_error_bubble_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/web_intent_picker_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/aura_shell/examples/bubble.cc View 3 chunks +1 line, -3 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 4 chunks +7 lines, -8 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M ui/views/bubble/bubble_delegate_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/examples/bubble_example.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
PTAL; thanks!
9 years ago (2011-12-07 05:01:40 UTC) #1
msw
+Sky for general OWNERS. +davemoore and stevenjb for chrome/browser/chromeos/status/OWNERS (noparent)
9 years ago (2011-12-07 18:15:16 UTC) #2
stevenjb
status area changes lgtm
9 years ago (2011-12-07 20:18:21 UTC) #3
sky
LGTM http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h File ui/views/bubble/bubble_delegate.h (right): http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h#newcode68 ui/views/bubble/bubble_delegate.h:68: void set_color(const SkColor& color) { color_ = color; ...
9 years ago (2011-12-07 22:12:46 UTC) #4
tfarina
http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h File ui/views/bubble/bubble_delegate.h (right): http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h#newcode68 ui/views/bubble/bubble_delegate.h:68: void set_color(const SkColor& color) { color_ = color; } ...
9 years ago (2011-12-07 22:15:18 UTC) #5
alicet1
lgtm thanks for the cleanup, mike!
9 years ago (2011-12-07 22:17:11 UTC) #6
msw
Done; landing after trybots. Thanks! http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h File ui/views/bubble/bubble_delegate.h (right): http://codereview.chromium.org/8833004/diff/2001/ui/views/bubble/bubble_delegate.h#newcode68 ui/views/bubble/bubble_delegate.h:68: void set_color(const SkColor& color) ...
9 years ago (2011-12-07 22:26:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8833004/8001
9 years ago (2011-12-07 23:21:14 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-08 01:28:13 UTC) #9 
Change committed as 113523

Powered by Google App Engine
This is Rietveld 408576698