Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: ui/aura_shell/examples/bubble.cc

Issue 8833004: Remove BubbleDelegateView ctor color arg, add simple setter/getter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pass set_color SkColor arg by value. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/web_intent_picker_view.cc ('k') | ui/views/bubble/bubble_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura_shell/examples/bubble.cc
diff --git a/ui/aura_shell/examples/bubble.cc b/ui/aura_shell/examples/bubble.cc
index 6eba6ba513f8ad2e0ee3c97ab66a191647815c0e..74d8040422d51071f93a319443bd19ff6b7a4c05 100644
--- a/ui/aura_shell/examples/bubble.cc
+++ b/ui/aura_shell/examples/bubble.cc
@@ -14,7 +14,6 @@ namespace examples {
struct BubbleConfig {
string16 label;
- SkColor color;
views::View* anchor_view;
views::BubbleBorder::ArrowLocation arrow;
};
@@ -22,7 +21,7 @@ struct BubbleConfig {
class ExampleBubbleDelegateView : public views::BubbleDelegateView {
public:
ExampleBubbleDelegateView(const BubbleConfig& config)
- : BubbleDelegateView(config.anchor_view, config.arrow, config.color),
+ : BubbleDelegateView(config.anchor_view, config.arrow),
label_(config.label) {}
virtual void Init() OVERRIDE {
@@ -38,7 +37,6 @@ class ExampleBubbleDelegateView : public views::BubbleDelegateView {
void CreatePointyBubble(views::View* anchor_view) {
BubbleConfig config;
config.label = ASCIIToUTF16("PointyBubble");
- config.color = SK_ColorWHITE;
config.anchor_view = anchor_view;
config.arrow = views::BubbleBorder::TOP_LEFT;
ExampleBubbleDelegateView* bubble = new ExampleBubbleDelegateView(config);
« no previous file with comments | « chrome/browser/ui/views/web_intent_picker_view.cc ('k') | ui/views/bubble/bubble_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698