Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3715)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 8833004: Remove BubbleDelegateView ctor color arg, add simple setter/getter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pass set_color SkColor arg by value. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | chrome/browser/ui/views/confirm_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
index d367d50404b5b4645bc54c2df4ceb05144bf83ed..820342371222edd74284c6b9b9802c606f2c0a85 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
@@ -45,9 +45,6 @@ static const int kTitlePadding = 4;
// of the field's left edge.
static const int kMinimumFieldSize = 180;
-// TODO(msw): Get color from theme/window color.
-static const SkColor kColor = SK_ColorWHITE;
-
// Declared in browser_dialogs.h so callers don't have to depend on our header.
namespace browser {
@@ -244,7 +241,7 @@ BookmarkBubbleView::BookmarkBubbleView(views::View* anchor_view,
Profile* profile,
const GURL& url,
bool newly_bookmarked)
- : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT, kColor),
+ : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
profile_(profile),
url_(url),
newly_bookmarked_(newly_bookmarked),
« no previous file with comments | « chrome/browser/ui/views/avatar_menu_bubble_view.cc ('k') | chrome/browser/ui/views/confirm_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698