Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Side by Side Diff: ui/aura_shell/examples/bubble.cc

Issue 8833004: Remove BubbleDelegateView ctor color arg, add simple setter/getter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pass set_color SkColor arg by value. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/views/web_intent_picker_view.cc ('k') | ui/views/bubble/bubble_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/utf_string_conversions.h" 5 #include "base/utf_string_conversions.h"
6 #include "ui/views/bubble/bubble_border.h" 6 #include "ui/views/bubble/bubble_border.h"
7 #include "ui/views/bubble/bubble_delegate.h" 7 #include "ui/views/bubble/bubble_delegate.h"
8 #include "ui/views/controls/label.h" 8 #include "ui/views/controls/label.h"
9 #include "ui/views/layout/fill_layout.h" 9 #include "ui/views/layout/fill_layout.h"
10 #include "ui/views/widget/widget.h" 10 #include "ui/views/widget/widget.h"
11 11
12 namespace aura_shell { 12 namespace aura_shell {
13 namespace examples { 13 namespace examples {
14 14
15 struct BubbleConfig { 15 struct BubbleConfig {
16 string16 label; 16 string16 label;
17 SkColor color;
18 views::View* anchor_view; 17 views::View* anchor_view;
19 views::BubbleBorder::ArrowLocation arrow; 18 views::BubbleBorder::ArrowLocation arrow;
20 }; 19 };
21 20
22 class ExampleBubbleDelegateView : public views::BubbleDelegateView { 21 class ExampleBubbleDelegateView : public views::BubbleDelegateView {
23 public: 22 public:
24 ExampleBubbleDelegateView(const BubbleConfig& config) 23 ExampleBubbleDelegateView(const BubbleConfig& config)
25 : BubbleDelegateView(config.anchor_view, config.arrow, config.color), 24 : BubbleDelegateView(config.anchor_view, config.arrow),
26 label_(config.label) {} 25 label_(config.label) {}
27 26
28 virtual void Init() OVERRIDE { 27 virtual void Init() OVERRIDE {
29 SetLayoutManager(new views::FillLayout()); 28 SetLayoutManager(new views::FillLayout());
30 views::Label* label = new views::Label(label_); 29 views::Label* label = new views::Label(label_);
31 AddChildView(label); 30 AddChildView(label);
32 } 31 }
33 32
34 private: 33 private:
35 string16 label_; 34 string16 label_;
36 }; 35 };
37 36
38 void CreatePointyBubble(views::View* anchor_view) { 37 void CreatePointyBubble(views::View* anchor_view) {
39 BubbleConfig config; 38 BubbleConfig config;
40 config.label = ASCIIToUTF16("PointyBubble"); 39 config.label = ASCIIToUTF16("PointyBubble");
41 config.color = SK_ColorWHITE;
42 config.anchor_view = anchor_view; 40 config.anchor_view = anchor_view;
43 config.arrow = views::BubbleBorder::TOP_LEFT; 41 config.arrow = views::BubbleBorder::TOP_LEFT;
44 ExampleBubbleDelegateView* bubble = new ExampleBubbleDelegateView(config); 42 ExampleBubbleDelegateView* bubble = new ExampleBubbleDelegateView(config);
45 views::BubbleDelegateView::CreateBubble(bubble); 43 views::BubbleDelegateView::CreateBubble(bubble);
46 bubble->Show(); 44 bubble->Show();
47 } 45 }
48 46
49 } // namespace examples 47 } // namespace examples
50 } // namespace aura_shell 48 } // namespace aura_shell
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/web_intent_picker_view.cc ('k') | ui/views/bubble/bubble_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698