Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().

Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().

This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to use CompletionCallback and fixes all users.

BUG=none
TEST=existing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113825

[awong, 2011-12-08 19:44:24]

SOCKET API CHANGE OF DOOM!

I'd like to get this quickly so if you cannot review this fast, please let me
know and I will find someone else.

I'm splitting this review into manageable chunks. Please only review your
portion.  

@jam (17 files):
  chrome/*
  content/*

@akalin (14 files):
   jingle/*

@jbates (16 files):
   net/curvecp/*

@cbentzel (14 files):
      1 net/base
      2 net/dns
      4 net/ftp
      7 net/http

@willchan (20 files):
      net/socket/client_socket_pool_base_unittest.cc
      net/socket/deterministic_socket_data_unittest.cc
      net/socket/sock*
      net/socket/stream_socket.h
      net/socket_stream/*
      net/spdy/*

@wtc (14 files):
     net/socket/ssl_*
     net/socket/tcp_*

@jhawkins (12 files):
     net/socket/trans_*
     net/socket/web_*

@mmenke (12 files):
     10 net/udp
      2 net/url_request

@sergeyu (21 files)
      2 remoting/jingle_glue
     19 remoting/protocol

@dmichael (2 files):
      2 webkit/plugins

[willchan no longer on Chromium, 2011-12-08 20:33:10]

I thought James Hawkins was doing this piecemeal? Not that I care too much.
I'll take a look anyway.

On Thu, Dec 8, 2011 at 11:44 AM, <ajwong@chromium.org> wrote:

> Reviewers: John Abd-El-Malek, akalin, jbates, cbentzel, willchan, wtc,
> James Hawkins, Matt Menke, sergeyu, dmichael,
>
> Message:
> SOCKET API CHANGE OF DOOM!
>
> I'd like to get this quickly so if you cannot review this fast, please let
> me
> know and I will find someone else.
>
> I'm splitting this review into manageable chunks. Please only review your
> portion.
>
> @jam (17 files):
>  chrome/*
>  content/*
>
> @akalin (14 files):
>   jingle/*
>
> @jbates (16 files):
>   net/curvecp/*
>
> @cbentzel (14 files):
>      1 net/base
>      2 net/dns
>      4 net/ftp
>      7 net/http
>
> @willchan (20 files):
>      net/socket/client_socket_pool_**base_unittest.cc
>      net/socket/deterministic_**socket_data_unittest.cc
>      net/socket/sock*
>      net/socket/stream_socket.h
>      net/socket_stream/*
>      net/spdy/*
>
> @wtc (14 files):
>     net/socket/ssl_*
>     net/socket/tcp_*
>
> @jhawkins (12 files):
>     net/socket/trans_*
>     net/socket/web_*
>
> @mmenke (12 files):
>     10 net/udp
>      2 net/url_request
>
> @sergeyu (21 files)
>      2 remoting/jingle_glue
>     19 remoting/protocol
>
> @dmichael (2 files):
>      2 webkit/plugins
>
>
> Description:
> Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().
>
> This changes Socket::Read(), Socket::Write, and StreamSocket::Connect() to
> use
> CompletionCallback and fixes all users.
>
> BUG=none
> TEST=existing.
>
>
> Please review this at
http://codereview.chromium.**org/8824006/<http://codereview.chromium.org/8824...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chromeos/web_**socket_proxy.cc
>  M chrome/browser/extensions/api/**socket/socket_api_controller.**cc
>  M chrome/browser/net/network_**stats.h
>  M chrome/browser/net/network_**stats.cc
>  M content/browser/renderer_host/**p2p/socket_host_tcp.h
>  M content/browser/renderer_host/**p2p/socket_host_tcp.cc
>  M content/browser/renderer_host/**p2p/socket_host_test_utils.h
>  M content/browser/renderer_host/**p2p/socket_host_udp.h
>  M content/browser/renderer_host/**p2p/socket_host_udp.cc
>  M content/browser/renderer_host/**p2p/socket_host_udp_unittest.**cc
>  M content/browser/renderer_host/**pepper_tcp_socket.h
>  M content/browser/renderer_host/**pepper_tcp_socket.cc
>  M content/browser/renderer_host/**pepper_udp_socket.h
>  M content/browser/renderer_host/**pepper_udp_socket.cc
>  M content/renderer/p2p/p2p_**transport_impl.h
>  M content/renderer/p2p/p2p_**transport_impl.cc
>  M content/renderer/p2p/p2p_**transport_impl_unittest.cc
>  M jingle/glue/channel_socket_**adapter.h
>  M jingle/glue/channel_socket_**adapter.cc
>  M jingle/glue/channel_socket_**adapter_unittest.cc
>  M jingle/glue/pseudotcp_adapter.**h
>  M jingle/glue/pseudotcp_adapter.**cc
>  M jingle/glue/pseudotcp_adapter_**unittest.cc
>  M jingle/notifier/base/chrome_**async_socket.h
>  M jingle/notifier/base/chrome_**async_socket.cc
>  M jingle/notifier/base/fake_ssl_**client_socket.h
>  M jingle/notifier/base/fake_ssl_**client_socket.cc
>  M jingle/notifier/base/fake_ssl_**client_socket_unittest.cc
>  M jingle/notifier/base/proxy_**resolving_client_socket.h
>  M jingle/notifier/base/proxy_**resolving_client_socket.cc
>  M jingle/notifier/base/proxy_**resolving_client_socket_**unittest.cc
>  M net/base/net_log.h
>  M net/curvecp/client_packetizer.**h
>  M net/curvecp/client_packetizer.**cc
>  M net/curvecp/curvecp_client_**socket.h
>  M net/curvecp/curvecp_client_**socket.cc
>  M net/curvecp/curvecp_server_**socket.h
>  M net/curvecp/curvecp_server_**socket.cc
>  M net/curvecp/curvecp_transfer_**unittest.cc
>  M net/curvecp/messenger.h
>  M net/curvecp/messenger.cc
>  M net/curvecp/packetizer.h
>  M net/curvecp/server_packetizer.**h
>  M net/curvecp/server_packetizer.**cc
>  M net/curvecp/test_client.h
>  M net/curvecp/test_client.cc
>  M net/curvecp/test_server.h
>  M net/curvecp/test_server.cc
>  M net/dns/dns_transaction.h
>  M net/dns/dns_transaction.cc
>  M net/ftp/ftp_network_**transaction.h
>  M net/ftp/ftp_network_**transaction.cc
>  M net/ftp/ftp_network_**transaction_unittest.cc
>  M net/ftp/ftp_transaction.h
>  M net/http/http_network_**transaction_unittest.cc
>  M net/http/http_proxy_client_**socket.h
>  M net/http/http_proxy_client_**socket.cc
>  M net/http/http_proxy_client_**socket_pool.h
>  M net/http/http_proxy_client_**socket_pool.cc
>  M net/http/http_stream_parser.h
>  M net/http/http_stream_parser.cc
>  M net/socket/client_socket_pool_**base_unittest.cc
>  M net/socket/deterministic_**socket_data_unittest.cc
>  M net/socket/socket.h
>  M net/socket/socket_test_util.h
>  M net/socket/socket_test_util.cc
>  M net/socket/socks5_client_**socket.h
>  M net/socket/socks5_client_**socket.cc
>  M net/socket/socks5_client_**socket_unittest.cc
>  M net/socket/socks_client_**socket.h
>  M net/socket/socks_client_**socket.cc
>  M net/socket/socks_client_**socket_pool.h
>  M net/socket/socks_client_**socket_pool.cc
>  M net/socket/socks_client_**socket_unittest.cc
>  M net/socket/ssl_client_socket_**mac.h
>  M net/socket/ssl_client_socket_**mac.cc
>  M net/socket/ssl_client_socket_**nss.h
>  M net/socket/ssl_client_socket_**nss.cc
>  M net/socket/ssl_client_socket_**openssl.h
>  M net/socket/ssl_client_socket_**openssl.cc
>  M net/socket/ssl_client_socket_**pool.h
>  M net/socket/ssl_client_socket_**pool.cc
>  M net/socket/ssl_client_socket_**unittest.cc
>  M net/socket/ssl_client_socket_**win.h
>  M net/socket/ssl_client_socket_**win.cc
>  M net/socket/ssl_server_socket_**nss.h
>  M net/socket/ssl_server_socket_**nss.cc
>  M net/socket/ssl_server_socket_**unittest.cc
>  M net/socket/stream_socket.h
>  M net/socket/tcp_client_socket_**libevent.h
>  M net/socket/tcp_client_socket_**libevent.cc
>  M net/socket/tcp_client_socket_**unittest.cc
>  M net/socket/tcp_client_socket_**win.h
>  M net/socket/tcp_client_socket_**win.cc
>  M net/socket/tcp_server_socket_**unittest.cc
>  M net/socket/transport_client_**socket_pool.h
>  M net/socket/transport_client_**socket_pool.cc
>  M net/socket/transport_client_**socket_pool_unittest.cc
>  M net/socket/transport_client_**socket_unittest.cc
>  M net/socket/web_socket_server_**socket.cc
>  M net/socket/web_socket_server_**socket_unittest.cc
>  M net/socket_stream/socket_**stream.h
>  M net/socket_stream/socket_**stream.cc
>  M net/spdy/spdy_proxy_client_**socket.h
>  M net/spdy/spdy_proxy_client_**socket.cc
>  M net/spdy/spdy_proxy_client_**socket_unittest.cc
>  M net/spdy/spdy_session.h
>  M net/spdy/spdy_session.cc
>  M net/udp/datagram_server_**socket.h
>  M net/udp/udp_client_socket.h
>  M net/udp/udp_client_socket.cc
>  M net/udp/udp_server_socket.h
>  M net/udp/udp_server_socket.cc
>  M net/udp/udp_socket_libevent.h
>  M net/udp/udp_socket_libevent.cc
>  M net/udp/udp_socket_unittest.cc
>  M net/udp/udp_socket_win.h
>  M net/udp/udp_socket_win.cc
>  M net/url_request/url_request_**ftp_job.h
>  M net/url_request/url_request_**ftp_job.cc
>  M remoting/jingle_glue/ssl_**socket_adapter.h
>  M remoting/jingle_glue/ssl_**socket_adapter.cc
>  M remoting/protocol/buffered_**socket_writer.h
>  M remoting/protocol/buffered_**socket_writer.cc
>  M remoting/protocol/fake_**session.h
>  M remoting/protocol/fake_**session.cc
>  M remoting/protocol/jingle_**session_unittest.cc
>  M remoting/protocol/jingle_**stream_connector.h
>  M remoting/protocol/jingle_**stream_connector.cc
>  M remoting/protocol/message_**reader.h
>  M remoting/protocol/message_**reader.cc
>  M remoting/protocol/pepper_**stream_channel.h
>  M remoting/protocol/pepper_**stream_channel.cc
>  M remoting/protocol/pepper_**transport_socket_adapter.h
>  M remoting/protocol/pepper_**transport_socket_adapter.cc
>  M remoting/protocol/socket_**reader_base.h
>  M remoting/protocol/socket_**reader_base.cc
>  M remoting/protocol/v1_client_**channel_authenticator.h
>  M remoting/protocol/v1_client_**channel_authenticator.cc
>  M remoting/protocol/v1_host_**channel_authenticator.h
>  M remoting/protocol/v1_host_**channel_authenticator.cc
>  M webkit/plugins/ppapi/ppb_**transport_impl.h
>  M webkit/plugins/ppapi/ppb_**transport_impl.cc
>
>
>

[dmichael (off chromium), 2011-12-08 20:35:35]

+viettrungluu, who is an OWNER for webkit/plugins/ppapi and more familiar with
ppb_transport

[awong, 2011-12-08 20:37:25]

On Thu, Dec 8, 2011 at 12:33 PM, William Chan (陈智昌)
<willchan@chromium.org>wrote:

> I thought James Hawkins was doing this piecemeal? Not that I care too
> much. I'll take a look anyway.


We collided, so I built on top of his work and finished it out.

-Albert



> On Thu, Dec 8, 2011 at 11:44 AM, <ajwong@chromium.org> wrote:
>
>> Reviewers: John Abd-El-Malek, akalin, jbates, cbentzel, willchan, wtc,
>> James Hawkins, Matt Menke, sergeyu, dmichael,
>>
>> Message:
>> SOCKET API CHANGE OF DOOM!
>>
>> I'd like to get this quickly so if you cannot review this fast, please
>> let me
>> know and I will find someone else.
>>
>> I'm splitting this review into manageable chunks. Please only review your
>> portion.
>>
>> @jam (17 files):
>>  chrome/*
>>  content/*
>>
>> @akalin (14 files):
>>   jingle/*
>>
>> @jbates (16 files):
>>   net/curvecp/*
>>
>> @cbentzel (14 files):
>>      1 net/base
>>      2 net/dns
>>      4 net/ftp
>>      7 net/http
>>
>> @willchan (20 files):
>>      net/socket/client_socket_pool_**base_unittest.cc
>>      net/socket/deterministic_**socket_data_unittest.cc
>>      net/socket/sock*
>>      net/socket/stream_socket.h
>>      net/socket_stream/*
>>      net/spdy/*
>>
>> @wtc (14 files):
>>     net/socket/ssl_*
>>     net/socket/tcp_*
>>
>> @jhawkins (12 files):
>>     net/socket/trans_*
>>     net/socket/web_*
>>
>> @mmenke (12 files):
>>     10 net/udp
>>      2 net/url_request
>>
>> @sergeyu (21 files)
>>      2 remoting/jingle_glue
>>     19 remoting/protocol
>>
>> @dmichael (2 files):
>>      2 webkit/plugins
>>
>>
>> Description:
>> Migrate net/socket/socket.h, net/socket/stream_socket.h to base::Bind().
>>
>> This changes Socket::Read(), Socket::Write, and StreamSocket::Connect()
>> to use
>> CompletionCallback and fixes all users.
>>
>> BUG=none
>> TEST=existing.
>>
>>
>> Please review this at
http://codereview.chromium.**org/8824006/<http://codereview.chromium.org/8824...
>>
>> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>>
>> Affected files:
>>  M chrome/browser/chromeos/web_**socket_proxy.cc
>>  M chrome/browser/extensions/api/**socket/socket_api_controller.**cc
>>  M chrome/browser/net/network_**stats.h
>>  M chrome/browser/net/network_**stats.cc
>>  M content/browser/renderer_host/**p2p/socket_host_tcp.h
>>  M content/browser/renderer_host/**p2p/socket_host_tcp.cc
>>  M content/browser/renderer_host/**p2p/socket_host_test_utils.h
>>  M content/browser/renderer_host/**p2p/socket_host_udp.h
>>  M content/browser/renderer_host/**p2p/socket_host_udp.cc
>>  M content/browser/renderer_host/**p2p/socket_host_udp_unittest.**cc
>>  M content/browser/renderer_host/**pepper_tcp_socket.h
>>  M content/browser/renderer_host/**pepper_tcp_socket.cc
>>  M content/browser/renderer_host/**pepper_udp_socket.h
>>  M content/browser/renderer_host/**pepper_udp_socket.cc
>>  M content/renderer/p2p/p2p_**transport_impl.h
>>  M content/renderer/p2p/p2p_**transport_impl.cc
>>  M content/renderer/p2p/p2p_**transport_impl_unittest.cc
>>  M jingle/glue/channel_socket_**adapter.h
>>  M jingle/glue/channel_socket_**adapter.cc
>>  M jingle/glue/channel_socket_**adapter_unittest.cc
>>  M jingle/glue/pseudotcp_adapter.**h
>>  M jingle/glue/pseudotcp_adapter.**cc
>>  M jingle/glue/pseudotcp_adapter_**unittest.cc
>>  M jingle/notifier/base/chrome_**async_socket.h
>>  M jingle/notifier/base/chrome_**async_socket.cc
>>  M jingle/notifier/base/fake_ssl_**client_socket.h
>>  M jingle/notifier/base/fake_ssl_**client_socket.cc
>>  M jingle/notifier/base/fake_ssl_**client_socket_unittest.cc
>>  M jingle/notifier/base/proxy_**resolving_client_socket.h
>>  M jingle/notifier/base/proxy_**resolving_client_socket.cc
>>  M jingle/notifier/base/proxy_**resolving_client_socket_**unittest.cc
>>  M net/base/net_log.h
>>  M net/curvecp/client_packetizer.**h
>>  M net/curvecp/client_packetizer.**cc
>>  M net/curvecp/curvecp_client_**socket.h
>>  M net/curvecp/curvecp_client_**socket.cc
>>  M net/curvecp/curvecp_server_**socket.h
>>  M net/curvecp/curvecp_server_**socket.cc
>>  M net/curvecp/curvecp_transfer_**unittest.cc
>>  M net/curvecp/messenger.h
>>  M net/curvecp/messenger.cc
>>  M net/curvecp/packetizer.h
>>  M net/curvecp/server_packetizer.**h
>>  M net/curvecp/server_packetizer.**cc
>>  M net/curvecp/test_client.h
>>  M net/curvecp/test_client.cc
>>  M net/curvecp/test_server.h
>>  M net/curvecp/test_server.cc
>>  M net/dns/dns_transaction.h
>>  M net/dns/dns_transaction.cc
>>  M net/ftp/ftp_network_**transaction.h
>>  M net/ftp/ftp_network_**transaction.cc
>>  M net/ftp/ftp_network_**transaction_unittest.cc
>>  M net/ftp/ftp_transaction.h
>>  M net/http/http_network_**transaction_unittest.cc
>>  M net/http/http_proxy_client_**socket.h
>>  M net/http/http_proxy_client_**socket.cc
>>  M net/http/http_proxy_client_**socket_pool.h
>>  M net/http/http_proxy_client_**socket_pool.cc
>>  M net/http/http_stream_parser.h
>>  M net/http/http_stream_parser.cc
>>  M net/socket/client_socket_pool_**base_unittest.cc
>>  M net/socket/deterministic_**socket_data_unittest.cc
>>  M net/socket/socket.h
>>  M net/socket/socket_test_util.h
>>  M net/socket/socket_test_util.cc
>>  M net/socket/socks5_client_**socket.h
>>  M net/socket/socks5_client_**socket.cc
>>  M net/socket/socks5_client_**socket_unittest.cc
>>  M net/socket/socks_client_**socket.h
>>  M net/socket/socks_client_**socket.cc
>>  M net/socket/socks_client_**socket_pool.h
>>  M net/socket/socks_client_**socket_pool.cc
>>  M net/socket/socks_client_**socket_unittest.cc
>>  M net/socket/ssl_client_socket_**mac.h
>>  M net/socket/ssl_client_socket_**mac.cc
>>  M net/socket/ssl_client_socket_**nss.h
>>  M net/socket/ssl_client_socket_**nss.cc
>>  M net/socket/ssl_client_socket_**openssl.h
>>  M net/socket/ssl_client_socket_**openssl.cc
>>  M net/socket/ssl_client_socket_**pool.h
>>  M net/socket/ssl_client_socket_**pool.cc
>>  M net/socket/ssl_client_socket_**unittest.cc
>>  M net/socket/ssl_client_socket_**win.h
>>  M net/socket/ssl_client_socket_**win.cc
>>  M net/socket/ssl_server_socket_**nss.h
>>  M net/socket/ssl_server_socket_**nss.cc
>>  M net/socket/ssl_server_socket_**unittest.cc
>>  M net/socket/stream_socket.h
>>  M net/socket/tcp_client_socket_**libevent.h
>>  M net/socket/tcp_client_socket_**libevent.cc
>>  M net/socket/tcp_client_socket_**unittest.cc
>>  M net/socket/tcp_client_socket_**win.h
>>  M net/socket/tcp_client_socket_**win.cc
>>  M net/socket/tcp_server_socket_**unittest.cc
>>  M net/socket/transport_client_**socket_pool.h
>>  M net/socket/transport_client_**socket_pool.cc
>>  M net/socket/transport_client_**socket_pool_unittest.cc
>>  M net/socket/transport_client_**socket_unittest.cc
>>  M net/socket/web_socket_server_**socket.cc
>>  M net/socket/web_socket_server_**socket_unittest.cc
>>  M net/socket_stream/socket_**stream.h
>>  M net/socket_stream/socket_**stream.cc
>>  M net/spdy/spdy_proxy_client_**socket.h
>>  M net/spdy/spdy_proxy_client_**socket.cc
>>  M net/spdy/spdy_proxy_client_**socket_unittest.cc
>>  M net/spdy/spdy_session.h
>>  M net/spdy/spdy_session.cc
>>  M net/udp/datagram_server_**socket.h
>>  M net/udp/udp_client_socket.h
>>  M net/udp/udp_client_socket.cc
>>  M net/udp/udp_server_socket.h
>>  M net/udp/udp_server_socket.cc
>>  M net/udp/udp_socket_libevent.h
>>  M net/udp/udp_socket_libevent.cc
>>  M net/udp/udp_socket_unittest.cc
>>  M net/udp/udp_socket_win.h
>>  M net/udp/udp_socket_win.cc
>>  M net/url_request/url_request_**ftp_job.h
>>  M net/url_request/url_request_**ftp_job.cc
>>  M remoting/jingle_glue/ssl_**socket_adapter.h
>>  M remoting/jingle_glue/ssl_**socket_adapter.cc
>>  M remoting/protocol/buffered_**socket_writer.h
>>  M remoting/protocol/buffered_**socket_writer.cc
>>  M remoting/protocol/fake_**session.h
>>  M remoting/protocol/fake_**session.cc
>>  M remoting/protocol/jingle_**session_unittest.cc
>>  M remoting/protocol/jingle_**stream_connector.h
>>  M remoting/protocol/jingle_**stream_connector.cc
>>  M remoting/protocol/message_**reader.h
>>  M remoting/protocol/message_**reader.cc
>>  M remoting/protocol/pepper_**stream_channel.h
>>  M remoting/protocol/pepper_**stream_channel.cc
>>  M remoting/protocol/pepper_**transport_socket_adapter.h
>>  M remoting/protocol/pepper_**transport_socket_adapter.cc
>>  M remoting/protocol/socket_**reader_base.h
>>  M remoting/protocol/socket_**reader_base.cc
>>  M remoting/protocol/v1_client_**channel_authenticator.h
>>  M remoting/protocol/v1_client_**channel_authenticator.cc
>>  M remoting/protocol/v1_host_**channel_authenticator.h
>>  M remoting/protocol/v1_host_**channel_authenticator.cc
>>  M webkit/plugins/ppapi/ppb_**transport_impl.h
>>  M webkit/plugins/ppapi/ppb_**transport_impl.cc
>>
>>
>>
>

[willchan no longer on Chromium, 2011-12-08 20:38:52]

net/ LGTM

[mmenke, 2011-12-08 20:58:45]

net/udp and net/url_request LGTM

[Avi (use Gerrit), 2011-12-08 21:23:26]

chrome/content LGTM

[awong, 2011-12-08 21:25:48]

Thanks guys!  Esp Will for doing more than his fair share.

Now all that's left is
  @akalin: jingle
  @sergeyu: remoting
  @trungl: webkit

-Albert

[viettrungluu, 2011-12-08 21:53:15]

lgtm

[Sergey Ulanov, 2011-12-08 21:55:12]

remoting LGTM

[awong, 2011-12-08 23:25:32]

sync team is on an offsite today.  Since the changes are so mechanical, csilv@ a
master base::Bind migration reviewer is going to step in for them.

[csilv, 2011-12-09 00:41:59]

LGTM on jingle/*

http://codereview.chromium.org/8824006/diff/14144/jingle/glue/channel_socket_...
File jingle/glue/channel_socket_adapter_unittest.cc (right):

http://codereview.chromium.org/8824006/diff/14144/jingle/glue/channel_socket_...
jingle/glue/channel_socket_adapter_unittest.cc:4: 
nit: include base/bind.h, base/bind_helpers.h

http://codereview.chromium.org/8824006/diff/14144/jingle/glue/pseudotcp_adapt...
File jingle/glue/pseudotcp_adapter.cc (right):

http://codereview.chromium.org/8824006/diff/14144/jingle/glue/pseudotcp_adapt...
jingle/glue/pseudotcp_adapter.cc:6: 
nit: include base/bind.h, base/bind_helpers.h

http://codereview.chromium.org/8824006/diff/14144/jingle/notifier/base/chrome...
File jingle/notifier/base/chrome_async_socket.cc (right):

http://codereview.chromium.org/8824006/diff/14144/jingle/notifier/base/chrome...
jingle/notifier/base/chrome_async_socket.cc:12: #include "base/bind.h"
nit: include base/bind_helpers.h

http://codereview.chromium.org/8824006/diff/14144/jingle/notifier/base/fake_s...
File jingle/notifier/base/fake_ssl_client_socket.cc (right):

http://codereview.chromium.org/8824006/diff/14144/jingle/notifier/base/fake_s...
jingle/notifier/base/fake_ssl_client_socket.cc:8: 
nit: include base/bind.h, base/bind_helpers.h

[Robert Nagy, 2011-12-11 14:28:54]

Hello,

This patchset breaks builds on *BSDs so I assume that something is used here
which is not supported by older gcc since linux was not broken which uses a
newer gcc than 4.2.1.

net/http/http_proxy_client_socket.cc: In member function 'virtual int
net::HttpProxyClientSocket::RestartWithAuth(net::OldCompletionCallback*)':
net/http/http_proxy_client_socket.cc:77: error: no matching function for call to
'Bind(<unresolved overloaded function type>,
base::internal::UnretainedWrapper<CallbackRunner<Tuple1<int> > >)'

[awong, 2011-12-11 18:25:58]

Quit possibly.  gcc 4.2.x is no longer supported and I don't have a setup
to test it easily.

However, that error looks strange.  I would now have expected that error on
gcc 4.2.1....

On Sun, Dec 11, 2011 at 6:28 AM, <robert.nagy@gmail.com> wrote:

> Hello,
>
> This patchset breaks builds on *BSDs so I assume that something is used
> here
> which is not supported by older gcc since linux was not broken which uses a
> newer gcc than 4.2.1.
>
> net/http/http_proxy_client_**socket.cc: In member function 'virtual int
> net::HttpProxyClientSocket::**RestartWithAuth(net::**
> OldCompletionCallback*)':
> net/http/http_proxy_client_**socket.cc:77: error: no matching function
> for call to
> 'Bind(<unresolved overloaded function type>,
> base::internal::**UnretainedWrapper<**CallbackRunner<Tuple1<int> > >)'
>
>
>
http://codereview.chromium.**org/8824006/<http://codereview.chromium.org/8824...
>

[Robert Nagy, 2011-12-11 19:33:02]

Well even the wiki page says that gcc >= 4.2 is supported, or am I lookin at the
wrong location?

On 2011/12/11 18:25:58, awong wrote:
> Quit possibly.  gcc 4.2.x is no longer supported and I don't have a setup
> to test it easily.
> 
> However, that error looks strange.  I would now have expected that error on
> gcc 4.2.1....
> 
> On Sun, Dec 11, 2011 at 6:28 AM, <mailto:robert.nagy@gmail.com> wrote:
> 
> > Hello,
> >
> > This patchset breaks builds on *BSDs so I assume that something is used
> > here
> > which is not supported by older gcc since linux was not broken which uses a
> > newer gcc than 4.2.1.
> >
> > net/http/http_proxy_client_**socket.cc: In member function 'virtual int
> > net::HttpProxyClientSocket::**RestartWithAuth(net::**
> > OldCompletionCallback*)':
> > net/http/http_proxy_client_**socket.cc:77: error: no matching function
> > for call to
> > 'Bind(<unresolved overloaded function type>,
> > base::internal::**UnretainedWrapper<**CallbackRunner<Tuple1<int> > >)'
> >
> >
> >
>
http://codereview.chromium.**org/8824006/%3Chttp://codereview.chromium.org/88...>
> >

[Robert Nagy, 2011-12-12 11:03:44]

Same issue on net/socket/web_socket_server_socket.cc:325

On 2011/12/11 19:33:02, Robert Nagy wrote:
> Well even the wiki page says that gcc >= 4.2 is supported, or am I lookin at
the
> wrong location?
> 
> On 2011/12/11 18:25:58, awong wrote:
> > Quit possibly.  gcc 4.2.x is no longer supported and I don't have a setup
> > to test it easily.
> > 
> > However, that error looks strange.  I would now have expected that error on
> > gcc 4.2.1....
> > 
> > On Sun, Dec 11, 2011 at 6:28 AM, <mailto:robert.nagy@gmail.com> wrote:
> > 
> > > Hello,
> > >
> > > This patchset breaks builds on *BSDs so I assume that something is used
> > > here
> > > which is not supported by older gcc since linux was not broken which uses
a
> > > newer gcc than 4.2.1.
> > >
> > > net/http/http_proxy_client_**socket.cc: In member function 'virtual int
> > > net::HttpProxyClientSocket::**RestartWithAuth(net::**
> > > OldCompletionCallback*)':
> > > net/http/http_proxy_client_**socket.cc:77: error: no matching function
> > > for call to
> > > 'Bind(<unresolved overloaded function type>,
> > > base::internal::**UnretainedWrapper<**CallbackRunner<Tuple1<int> > >)'
> > >
> > >
> > >
> >
>
http://codereview.chromium.**org/8824006/%253Chttp://codereview.chromium.org/...>
> > >

[awong, 2011-12-12 18:56:48]

I think that's slightly out of date.  4.2 support is on its way out.

That having been said, I expect to be removing this code soon as part of an
unrelated change.  If you'd like, you can open a change bug on it.

-Albert


On Mon, Dec 12, 2011 at 3:03 AM, <robert.nagy@gmail.com> wrote:

> Same issue on net/socket/web_socket_server_**socket.cc:325
>
>
> On 2011/12/11 19:33:02, Robert Nagy wrote:
>
>> Well even the wiki page says that gcc >= 4.2 is supported, or am I lookin
>> at
>>
> the
>
>> wrong location?
>>
>
>  On 2011/12/11 18:25:58, awong wrote:
>> > Quit possibly.  gcc 4.2.x is no longer supported and I don't have a
>> setup
>> > to test it easily.
>> >
>> > However, that error looks strange.  I would now have expected that
>> error on
>> > gcc 4.2.1....
>> >
>> > On Sun, Dec 11, 2011 at 6:28 AM, <mailto:robert.nagy@gmail.com> wrote:
>> >
>> > > Hello,
>> > >
>> > > This patchset breaks builds on *BSDs so I assume that something is
>> used
>> > > here
>> > > which is not supported by older gcc since linux was not broken which
>> uses
>>
> a
>
>> > > newer gcc than 4.2.1.
>> > >
>> > > net/http/http_proxy_client_****socket.cc: In member function
>> 'virtual int
>> > > net::HttpProxyClientSocket::****RestartWithAuth(net::**
>> > > OldCompletionCallback*)':
>> > > net/http/http_proxy_client_****socket.cc:77: error: no matching
>> function
>> > > for call to
>> > > 'Bind(<unresolved overloaded function type>,
>> > > base::internal::****UnretainedWrapper<****CallbackRunner<Tuple1<int>
>> > >)'
>> > >
>> > >
>> > >
>> >
>>
>
> http://codereview.chromium.****org/8824006/%253Chttp://codere**
> view.chromium.org/8824006/ <http://codereview.chromium.org/8824006/>>
>
>> > >
>>
>
>
>
http://codereview.chromium.**org/8824006/<http://codereview.chromium.org/8824...
>

[Robert Nagy, 2011-12-12 19:20:10]

If you have a change that removes this, I can probably wait for that.
The only problem with removing 4.2 support is that, 4.2.1 is the last GPLv2
version of GCC and a lot of people just don't like using a GPLv3 compiler.

On 2011/12/12 18:56:48, awong wrote:
> I think that's slightly out of date.  4.2 support is on its way out.
> 
> That having been said, I expect to be removing this code soon as part of an
> unrelated change.  If you'd like, you can open a change bug on it.
> 
> -Albert
> 
> 
> On Mon, Dec 12, 2011 at 3:03 AM, <mailto:robert.nagy@gmail.com> wrote:
> 
> > Same issue on net/socket/web_socket_server_**socket.cc:325
> >
> >
> > On 2011/12/11 19:33:02, Robert Nagy wrote:
> >
> >> Well even the wiki page says that gcc >= 4.2 is supported, or am I lookin
> >> at
> >>
> > the
> >
> >> wrong location?
> >>
> >
> >  On 2011/12/11 18:25:58, awong wrote:
> >> > Quit possibly.  gcc 4.2.x is no longer supported and I don't have a
> >> setup
> >> > to test it easily.
> >> >
> >> > However, that error looks strange.  I would now have expected that
> >> error on
> >> > gcc 4.2.1....
> >> >
> >> > On Sun, Dec 11, 2011 at 6:28 AM, <mailto:robert.nagy@gmail.com> wrote:
> >> >
> >> > > Hello,
> >> > >
> >> > > This patchset breaks builds on *BSDs so I assume that something is
> >> used
> >> > > here
> >> > > which is not supported by older gcc since linux was not broken which
> >> uses
> >>
> > a
> >
> >> > > newer gcc than 4.2.1.
> >> > >
> >> > > net/http/http_proxy_client_****socket.cc: In member function
> >> 'virtual int
> >> > > net::HttpProxyClientSocket::****RestartWithAuth(net::**
> >> > > OldCompletionCallback*)':
> >> > > net/http/http_proxy_client_****socket.cc:77: error: no matching
> >> function
> >> > > for call to
> >> > > 'Bind(<unresolved overloaded function type>,
> >> > > base::internal::****UnretainedWrapper<****CallbackRunner<Tuple1<int>
> >> > >)'
> >> > >
> >> > >
> >> > >
> >> >
> >>
> >
> > http://codereview.chromium.****org/8824006/%25253Chttp://codere**
> > view.chromium.org/8824006/ <http://codereview.chromium.org/8824006/>>
> >
> >> > >
> >>
> >
> >
> >
>
http://codereview.chromium.**org/8824006/%3Chttp://codereview.chromium.org/88...>
> >