Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, nkostylev+watch_chromium.org, jam, brettw-cc_chromium.org, kkania, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, robertshield, Paweł Hajdan Jr., ajwong+watch_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove deprecated TabContentsDelegate::OpenURLFromTab variant BUG=105028 TEST=no functional change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112706

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3227 lines, -2251 lines) Patch
M DEPS View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M base/base.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit.cc View 1 2 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/browser_process.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/bug_report_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/registration_screen.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 4 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/accessibility_menu_button_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/caps_lock_menu_button_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/power_menu_button_browsertest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/status_area_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.h View 1 2 4 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 4 chunks +3 lines, -22 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_importer_utils_win.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/io_thread.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/oom_priority_manager_browsertest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugin_observer.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller.cc View 1 2 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/policy/device_token_fetcher.cc View 1 2 1 chunk +12 lines, -5 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_histograms.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/process_singleton_linux.cc View 1 2 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 4 chunks +23 lines, -7 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/image_editor.js View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 2 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 2 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 15 chunks +27 lines, -22 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 1 2 4 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/performance/sessions_sync_perf_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/insecure_content_infobar_delegate.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 2 38 chunks +49 lines, -40 lines 0 comments Download
M chrome/browser/tabs/default_tab_handler.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/default_tab_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_delegate.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 4 chunks +10 lines, -16 lines 0 comments Download
M chrome/browser/ui/browser_navigator.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_html_delegate_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_html_delegate_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/global_history_menu.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/page_info_bubble_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/sad_tab_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/gtk/view_id_util_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_intent_picker_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt_browsertest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/aura/chrome_shell_delegate.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/aura/status_area_host_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_gtk.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_html_delegate_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dom_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/notifications/balloon_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/default_tab_drag_controller.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/default_tab_drag_controller.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/html_dialog_tab_contents_delegate_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_unittest.cc View 1 2 6 chunks +16 lines, -8 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
A chrome/tools/build/win/resedit.py View 1 2 1 chunk +320 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/debugger/devtools_manager_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper_tcp_socket.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/pepper_udp_socket.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 1 2 37 chunks +64 lines, -56 lines 0 comments Download
M content/browser/tab_contents/navigation_entry.h View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/navigation_entry.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry_unittest.cc View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/tab_contents/page_navigator.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/page_navigator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 14 chunks +26 lines, -21 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.cc View 1 2 3 chunks +6 lines, -21 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate_unittest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_observer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 6 chunks +10 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/browser_thread.h View 1 2 3 chunks +21 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/frame_navigate_params.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A content/public/common/referrer.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 2 4 chunks +65 lines, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 1 2 2 chunks +167 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 6 chunks +43 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 22 chunks +141 lines, -22 lines 0 comments Download
M content/shell/shell.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_tcp_socket_private_proxy.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M ppapi/proxy/ppb_tcp_socket_private_proxy.cc View 1 2 2 chunks +32 lines, -321 lines 0 comments Download
M ppapi/proxy/ppb_udp_socket_private_proxy.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_udp_socket_private_proxy.cc View 1 2 2 chunks +24 lines, -219 lines 0 comments Download
A ppapi/shared_impl/private/tcp_socket_private_impl.h View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
A ppapi/shared_impl/private/tcp_socket_private_impl.cc View 1 2 1 chunk +289 lines, -0 lines 0 comments Download
A ppapi/shared_impl/private/udp_socket_private_impl.h View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A ppapi/shared_impl/private/udp_socket_private_impl.cc View 1 2 1 chunk +209 lines, -0 lines 0 comments Download
A ppapi/tests/test_tcp_socket_private_shared.h View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A ppapi/tests/test_tcp_socket_private_shared.cc View 1 2 1 chunk +271 lines, -0 lines 0 comments Download
A ppapi/tests/test_udp_socket_private_shared.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A ppapi/tests/test_udp_socket_private_shared.cc View 1 2 1 chunk +182 lines, -0 lines 0 comments Download
M ppapi/thunk/ppb_tcp_socket_private_api.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_udp_socket_private_api.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M testing/gtest.gyp View 1 2 4 chunks +12 lines, -2 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 2 3 chunks +32 lines, -710 lines 0 comments Download
A + tools/valgrind/drmemory/suppressions_full.txt View 1 2 13 chunks +51 lines, -254 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M ui/gfx/render_text.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/context_menu.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/context_menu.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 1 2 2 chunks +30 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_tcp_socket_private_impl.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_tcp_socket_private_impl.cc View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_udp_socket_private_impl.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_udp_socket_private_impl.cc View 1 2 1 chunk +71 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years ago (2011-12-02 10:50:53 UTC) #1
Avi (use Gerrit)
lgtm
9 years ago (2011-12-02 14:25:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8772041/3001
9 years ago (2011-12-02 14:34:19 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-02 15:51:07 UTC) #4 
Change committed as 112706

Powered by Google App Engine
This is Rietveld 408576698