Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/debugger/devtools_window.h

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 void ScheduleAction(DevToolsToggleAction action); 92 void ScheduleAction(DevToolsToggleAction action);
93 void DoAction(); 93 void DoAction();
94 static GURL GetDevToolsUrl(Profile* profile, bool docked, 94 static GURL GetDevToolsUrl(Profile* profile, bool docked,
95 bool shared_worker_frontend); 95 bool shared_worker_frontend);
96 void UpdateTheme(); 96 void UpdateTheme();
97 void AddDevToolsExtensionsToClient(); 97 void AddDevToolsExtensionsToClient();
98 void CallClientFunction(const string16& function_name, 98 void CallClientFunction(const string16& function_name,
99 const base::Value& arg); 99 const base::Value& arg);
100 // Overridden from TabContentsDelegate. 100 // Overridden from TabContentsDelegate.
101 // Deprecated. Use two-arguments variant instead.
102 virtual TabContents* OpenURLFromTab(
103 TabContents* source,
104 const GURL& url,
105 const GURL& referrer,
106 WindowOpenDisposition disposition,
107 content::PageTransition transition) OVERRIDE;
108 virtual TabContents* OpenURLFromTab(TabContents* source, 101 virtual TabContents* OpenURLFromTab(TabContents* source,
109 const OpenURLParams& params) OVERRIDE; 102 const OpenURLParams& params) OVERRIDE;
110 virtual void AddNewContents(TabContents* source, 103 virtual void AddNewContents(TabContents* source,
111 TabContents* new_contents, 104 TabContents* new_contents,
112 WindowOpenDisposition disposition, 105 WindowOpenDisposition disposition,
113 const gfx::Rect& initial_pos, 106 const gfx::Rect& initial_pos,
114 bool user_gesture) OVERRIDE; 107 bool user_gesture) OVERRIDE;
115 virtual void CloseContents(TabContents* source) OVERRIDE {} 108 virtual void CloseContents(TabContents* source) OVERRIDE {}
116 virtual bool CanReloadContents(TabContents* source) const OVERRIDE; 109 virtual bool CanReloadContents(TabContents* source) const OVERRIDE;
117 virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event, 110 virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
(...skipping 27 matching lines...) Expand all
145 Browser* browser_; 138 Browser* browser_;
146 bool docked_; 139 bool docked_;
147 bool is_loaded_; 140 bool is_loaded_;
148 DevToolsToggleAction action_on_load_; 141 DevToolsToggleAction action_on_load_;
149 content::NotificationRegistrar registrar_; 142 content::NotificationRegistrar registrar_;
150 content::DevToolsClientHost* frontend_host_; 143 content::DevToolsClientHost* frontend_host_;
151 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 144 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
152 }; 145 };
153 146
154 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_ 147 #endif // CHROME_BROWSER_DEBUGGER_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/debugger/devtools_sanity_unittest.cc ('k') | chrome/browser/debugger/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698