Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: chrome/browser/ui/blocked_content/blocked_content_container.h

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Defines the public interface for the blocked content (including popup) 5 // Defines the public interface for the blocked content (including popup)
6 // notifications. This interface should only be used by the 6 // notifications. This interface should only be used by the
7 // BlockedContentTabHelper. Users and subclasses of TabContents/ 7 // BlockedContentTabHelper. Users and subclasses of TabContents/
8 // TabContentsWrapper should use the appropriate methods on 8 // TabContentsWrapper should use the appropriate methods on
9 // BlockedContentTabHelper to access information about blocked content. 9 // BlockedContentTabHelper to access information about blocked content.
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 // Removes all blocked contents. 50 // Removes all blocked contents.
51 void Clear(); 51 void Clear();
52 52
53 // Overridden from BlockedContentTabHelperDelegate: 53 // Overridden from BlockedContentTabHelperDelegate:
54 virtual TabContentsWrapper* GetConstrainingContentsWrapper( 54 virtual TabContentsWrapper* GetConstrainingContentsWrapper(
55 TabContentsWrapper* source) OVERRIDE; 55 TabContentsWrapper* source) OVERRIDE;
56 56
57 // Overridden from TabContentsDelegate: 57 // Overridden from TabContentsDelegate:
58 58
59 // Forwards OpenURLFromTab to our |owner_|. 59 // Forwards OpenURLFromTab to our |owner_|.
60 // Deprecated. Please use the two-arguments variant.
61 // TODO(adriansc): Remove method once refactoring changed all call sites.
62 virtual TabContents* OpenURLFromTab(
63 TabContents* source,
64 const GURL& url, const GURL& referrer,
65 WindowOpenDisposition disposition,
66 content::PageTransition transition) OVERRIDE;
67 virtual TabContents* OpenURLFromTab(TabContents* source, 60 virtual TabContents* OpenURLFromTab(TabContents* source,
68 const OpenURLParams& params) OVERRIDE; 61 const OpenURLParams& params) OVERRIDE;
69 62
70 // Forwards AddNewContents to our |owner_|. 63 // Forwards AddNewContents to our |owner_|.
71 virtual void AddNewContents(TabContents* source, 64 virtual void AddNewContents(TabContents* source,
72 TabContents* new_contents, 65 TabContents* new_contents,
73 WindowOpenDisposition disposition, 66 WindowOpenDisposition disposition,
74 const gfx::Rect& initial_position, 67 const gfx::Rect& initial_position,
75 bool user_gesture) OVERRIDE; 68 bool user_gesture) OVERRIDE;
76 69
(...skipping 22 matching lines...) Expand all
99 // The TabContents that owns and constrains this BlockedContentContainer. 92 // The TabContents that owns and constrains this BlockedContentContainer.
100 TabContentsWrapper* owner_; 93 TabContentsWrapper* owner_;
101 94
102 // Information about all blocked contents. 95 // Information about all blocked contents.
103 BlockedContents blocked_contents_; 96 BlockedContents blocked_contents_;
104 97
105 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedContentContainer); 98 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedContentContainer);
106 }; 99 };
107 100
108 #endif // CHROME_BROWSER_UI_BLOCKED_CONTENT_BLOCKED_CONTENT_CONTAINER_H_ 101 #endif // CHROME_BROWSER_UI_BLOCKED_CONTENT_BLOCKED_CONTENT_CONTAINER_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/auto_login_prompter.cc ('k') | chrome/browser/ui/blocked_content/blocked_content_container.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698