Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: chrome/browser/external_tab_container_win.h

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/external_tab_container_win.h
diff --git a/chrome/browser/external_tab_container_win.h b/chrome/browser/external_tab_container_win.h
index 550a5178955c648ba824db91fbd6c77b3281d60c..8d593d77733af2adc18d9b89cea90d59460da8ae 100644
--- a/chrome/browser/external_tab_container_win.h
+++ b/chrome/browser/external_tab_container_win.h
@@ -79,7 +79,7 @@ class ExternalTabContainer : public TabContentsDelegate,
bool handle_top_level_requests,
TabContentsWrapper* existing_tab_contents,
const GURL& initial_url,
- const GURL& referrer,
+ const content::Referrer& referrer,
bool infobars_enabled,
bool supports_full_tab_mode);
@@ -120,14 +120,6 @@ class ExternalTabContainer : public TabContentsDelegate,
// Overridden from TabContentsDelegate:
- // Deprecated. Please used two-arguments variant.
- // TODO(adriansc): Remove method once refactoring changed all call sites.
- virtual TabContents* OpenURLFromTab(
- TabContents* source,
- const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- content::PageTransition transition) OVERRIDE;
virtual TabContents* OpenURLFromTab(TabContents* source,
const OpenURLParams& params) OVERRIDE;
virtual void NavigationStateChanged(const TabContents* source,
@@ -247,7 +239,7 @@ class ExternalTabContainer : public TabContentsDelegate,
bool InitNavigationInfo(NavigationInfo* nav_info,
content::NavigationType nav_type,
int relative_offset);
- void Navigate(const GURL& url, const GURL& referrer);
+ void Navigate(const GURL& url, const content::Referrer& referrer);
friend class base::RefCounted<ExternalTabContainer>;
@@ -374,13 +366,6 @@ class TemporaryPopupExternalTabContainer : public ExternalTabContainer {
virtual void Observe(int type, const content::NotificationSource& source,
const content::NotificationDetails& details) {}
- // Deprecated. Please use the two-argument variant.
- // TODO(adriansc): Remove method once refactoring changed all call sites.
- virtual TabContents* OpenURLFromTab(
- TabContents* source, const GURL& url,
- const GURL& referrer,
- WindowOpenDisposition disposition,
- content::PageTransition transition) OVERRIDE;
virtual TabContents* OpenURLFromTab(TabContents* source,
const OpenURLParams& params) OVERRIDE;
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/browser/external_tab_container_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698