Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: content/browser/tab_contents/tab_contents_delegate.h

Issue 8772041: Remove deprecated TabContentsDelegate::OpenURLFromTab variant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_ 5 #ifndef CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_
6 #define CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_ 6 #define CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 // Opens a new URL inside the passed in TabContents (if source is 0 open 59 // Opens a new URL inside the passed in TabContents (if source is 0 open
60 // in the current front-most tab), unless |disposition| indicates the url 60 // in the current front-most tab), unless |disposition| indicates the url
61 // should be opened in a new tab or window. 61 // should be opened in a new tab or window.
62 // 62 //
63 // A NULL source indicates the current tab (callers should probably use 63 // A NULL source indicates the current tab (callers should probably use
64 // OpenURL() for these cases which does it for you). 64 // OpenURL() for these cases which does it for you).
65 65
66 // Returns the TabContents the URL is opened in, or NULL if the URL wasn't 66 // Returns the TabContents the URL is opened in, or NULL if the URL wasn't
67 // opened immediately. 67 // opened immediately.
68 // Deprecated. Please use the two-arguments method instead.
69 // TODO(adriansc): Remove this method once refactoring changed all call sites.
70 virtual TabContents* OpenURLFromTab(TabContents* source,
71 const GURL& url,
72 const GURL& referrer,
73 WindowOpenDisposition disposition,
74 content::PageTransition transition);
75
76 virtual TabContents* OpenURLFromTab(TabContents* source, 68 virtual TabContents* OpenURLFromTab(TabContents* source,
77 const OpenURLParams& params); 69 const OpenURLParams& params);
78 70
79 // Called to inform the delegate that the tab content's navigation state 71 // Called to inform the delegate that the tab content's navigation state
80 // changed. The |changed_flags| indicates the parts of the navigation state 72 // changed. The |changed_flags| indicates the parts of the navigation state
81 // that have been updated, and is any combination of the 73 // that have been updated, and is any combination of the
82 // |TabContents::InvalidateTypes| bits. 74 // |TabContents::InvalidateTypes| bits.
83 virtual void NavigationStateChanged(const TabContents* source, 75 virtual void NavigationStateChanged(const TabContents* source,
84 unsigned changed_flags); 76 unsigned changed_flags);
85 77
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 void Attach(TabContents* source); 371 void Attach(TabContents* source);
380 372
381 // Called when |this| is no longer the TabContentsDelegate for |source|. 373 // Called when |this| is no longer the TabContentsDelegate for |source|.
382 void Detach(TabContents* source); 374 void Detach(TabContents* source);
383 375
384 // The TabContents that this is currently a delegate for. 376 // The TabContents that this is currently a delegate for.
385 std::set<TabContents*> attached_contents_; 377 std::set<TabContents*> attached_contents_;
386 }; 378 };
387 379
388 #endif // CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_ 380 #endif // CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_
OLDNEW
« no previous file with comments | « content/browser/tab_contents/tab_contents.cc ('k') | content/browser/tab_contents/tab_contents_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698