Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel")

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed)

Created:
9 years ago by Mihai Parparita -not on Chrome

Modified:
9 years ago

Reviewers:
miket_OOO

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make platform apps use and require a different container ("shell" instead of "panel") For now (on GTK only), "shell" windows are not drawn with a frame at all. R=miket@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112378

Patch Set 1 #

Patch Set 2 : Add "manifest_version": 2 #

Patch Set 3 : Fix socket test #

Patch Set 4 : Fix socket test #

Total comments: 6

Patch Set 5 : Add shell to BrowserTest.StartMaximized #

Patch Set 6 : Rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -18 lines)			Patch
M	chrome/browser/extensions/extension_prefs.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
A	chrome/browser/extensions/platform_app_browsertest.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.h	View	1 2 3 4 5	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2 3 4 5	3 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_browsertest.cc	View	1 2 3 4	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_titlebar.cc	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 2 3 4 5	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_manifests_unittest.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/socket/api/manifest.json	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/manifest_tests/init_valid_platform_app.json	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A	chrome/test/data/extensions/platform_app/empty.html	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/platform_app/manifest.json	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

miket_OOO

LGTM. Consider killing the platform_app manifest key, if shell maps 1:1 to that extension type. ...

9 years ago (2011-11-30 19:29:13 UTC) #2

Mihai Parparita -not on Chrome

http://codereview.chromium.org/8734016/diff/9001/chrome/browser/extensions/platform_app_browsertest.cc File chrome/browser/extensions/platform_app_browsertest.cc (right): http://codereview.chromium.org/8734016/diff/9001/chrome/browser/extensions/platform_app_browsertest.cc#newcode49 chrome/browser/extensions/platform_app_browsertest.cc:49: LoadAndLaunchPlatformApp("platform_app"); On 2011/11/30 19:29:13, miket wrote: > Unless you ...

9 years ago (2011-11-30 22:38:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/8734016/15002

9 years ago (2011-12-01 00:13:24 UTC) #4

Change committed as 112378

Expand Messages | Collapse Messages