Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: chrome/common/extensions/extension_constants.cc

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_constants.h" 5 #include "chrome/common/extensions/extension_constants.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 const char kIncognitoSpanning[] = "spanning"; 120 const char kIncognitoSpanning[] = "spanning";
121 const char kIntentDispositionWindow[] = "window"; 121 const char kIntentDispositionWindow[] = "window";
122 const char kIntentDispositionInline[] = "inline"; 122 const char kIntentDispositionInline[] = "inline";
123 const char kIsolatedStorage[] = "storage"; 123 const char kIsolatedStorage[] = "storage";
124 const char kRunAtDocumentStart[] = "document_start"; 124 const char kRunAtDocumentStart[] = "document_start";
125 const char kRunAtDocumentEnd[] = "document_end"; 125 const char kRunAtDocumentEnd[] = "document_end";
126 const char kRunAtDocumentIdle[] = "document_idle"; 126 const char kRunAtDocumentIdle[] = "document_idle";
127 const char kPageActionTypeTab[] = "tab"; 127 const char kPageActionTypeTab[] = "tab";
128 const char kPageActionTypePermanent[] = "permanent"; 128 const char kPageActionTypePermanent[] = "permanent";
129 const char kLaunchContainerPanel[] = "panel"; 129 const char kLaunchContainerPanel[] = "panel";
130 const char kLaunchContainerShell[] = "shell";
130 const char kLaunchContainerTab[] = "tab"; 131 const char kLaunchContainerTab[] = "tab";
131 const char kLaunchContainerWindow[] = "window"; 132 const char kLaunchContainerWindow[] = "window";
132 } // namespace extension_manifest_values 133 } // namespace extension_manifest_values
133 134
134 // Extension-related error messages. Some of these are simple patterns, where a 135 // Extension-related error messages. Some of these are simple patterns, where a
135 // '*' is replaced at runtime with a specific value. This is used instead of 136 // '*' is replaced at runtime with a specific value. This is used instead of
136 // printf because we want to unit test them and scanf is hard to make 137 // printf because we want to unit test them and scanf is hard to make
137 // cross-platform. 138 // cross-platform.
138 namespace extension_manifest_errors { 139 namespace extension_manifest_errors {
139 const char kAppsNotEnabled[] = 140 const char kAppsNotEnabled[] =
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 const char kInvalidIsolationValue[] = 250 const char kInvalidIsolationValue[] =
250 "Invalid value for 'app.isolation[*]'."; 251 "Invalid value for 'app.isolation[*]'.";
251 const char kInvalidJs[] = 252 const char kInvalidJs[] =
252 "Invalid value for 'content_scripts[*].js[*]'."; 253 "Invalid value for 'content_scripts[*].js[*]'.";
253 const char kInvalidJsList[] = 254 const char kInvalidJsList[] =
254 "Required value 'content_scripts[*].js' is invalid."; 255 "Required value 'content_scripts[*].js' is invalid.";
255 const char kInvalidKey[] = 256 const char kInvalidKey[] =
256 "Value 'key' is missing or invalid."; 257 "Value 'key' is missing or invalid.";
257 const char kInvalidLaunchContainer[] = 258 const char kInvalidLaunchContainer[] =
258 "Invalid value for 'app.launch.container'."; 259 "Invalid value for 'app.launch.container'.";
260 const char kInvalidLaunchContainerForNonPlatform[] =
261 "'app.launch.container' = 'shell' can only be used with platform_app.";
259 const char kInvalidLaunchContainerForPlatform[] = 262 const char kInvalidLaunchContainerForPlatform[] =
260 "platform_app requires 'app.launch.container' == 'panel'."; 263 "platform_app requires 'app.launch.container' == 'shell'.";
261 const char kInvalidLaunchHeight[] = 264 const char kInvalidLaunchHeight[] =
262 "Invalid value for 'app.launch.height'."; 265 "Invalid value for 'app.launch.height'.";
263 const char kInvalidLaunchHeightContainer[] = 266 const char kInvalidLaunchHeightContainer[] =
264 "Invalid container type for 'app.launch.height'."; 267 "Invalid container type for 'app.launch.height'.";
265 const char kInvalidLaunchLocalPath[] = 268 const char kInvalidLaunchLocalPath[] =
266 "Invalid value for 'app.launch.local_path'."; 269 "Invalid value for 'app.launch.local_path'.";
267 const char kInvalidLaunchWebURL[] = 270 const char kInvalidLaunchWebURL[] =
268 "Invalid value for 'app.launch.web_url'."; 271 "Invalid value for 'app.launch.web_url'.";
269 const char kInvalidLaunchWidth[] = 272 const char kInvalidLaunchWidth[] =
270 "Invalid value for 'app.launch.width'."; 273 "Invalid value for 'app.launch.width'.";
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
486 const char kCloudPrintAppId[] = "mfehgcgbbipciphmccgaenjidiccnmng"; 489 const char kCloudPrintAppId[] = "mfehgcgbbipciphmccgaenjidiccnmng";
487 const char kAppsPromoHistogram[] = "Extensions.AppsPromo"; 490 const char kAppsPromoHistogram[] = "Extensions.AppsPromo";
488 const char kAppLaunchHistogram[] = "Extensions.AppLaunch"; 491 const char kAppLaunchHistogram[] = "Extensions.AppLaunch";
489 #if defined(OS_CHROMEOS) 492 #if defined(OS_CHROMEOS)
490 const char kAccessExtensionPath[] = 493 const char kAccessExtensionPath[] =
491 "/usr/share/chromeos-assets/accessibility/extensions"; 494 "/usr/share/chromeos-assets/accessibility/extensions";
492 const char kChromeVoxDirectoryName[] = "access_chromevox"; 495 const char kChromeVoxDirectoryName[] = "access_chromevox";
493 #endif 496 #endif
494 497
495 } 498 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_manifests_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698