Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6174)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/gtk/browser_titlebar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index e52165763d1b0a010f8b8a2582c4150ebb6d9a83..173945ff678f1639dc505890b7c149dbce629a86 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1092,7 +1092,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, OpenAppWindowLikeNtp) {
IN_PROC_BROWSER_TEST_F(BrowserTest, StartMaximized) {
// Can't test TYPE_PANEL as they are currently created differently (and can't
// end up maximized).
- Browser::Type types[] = { Browser::TYPE_TABBED, Browser::TYPE_POPUP };
+ Browser::Type types[] =
+ { Browser::TYPE_TABBED, Browser::TYPE_POPUP, Browser::TYPE_SHELL };
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(types); ++i) {
Browser* max_browser = new Browser(types[i], browser()->profile());
max_browser->set_show_state(ui::SHOW_STATE_MAXIMIZED);
@@ -1112,7 +1113,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, StartMaximized) {
IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_StartMinimized) {
// Can't test TYPE_PANEL as they are currently created differently (and can't
// end up minimized).
- Browser::Type types[] = { Browser::TYPE_TABBED, Browser::TYPE_POPUP };
+ Browser::Type types[] =
+ { Browser::TYPE_TABBED, Browser::TYPE_POPUP, Browser::TYPE_SHELL };
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(types); ++i) {
Browser* min_browser = new Browser(types[i], browser()->profile());
min_browser->set_show_state(ui::SHOW_STATE_MINIMIZED);
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/gtk/browser_titlebar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698