Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5375)

Unified Diff: chrome/common/extensions/extension_constants.h

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_constants.h
diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index 169e97e7c34a592f94f29f92cc5d6c4ce5b80977..8c988f3fc8b7e11bd591e41dccdf8d92bfd15767 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -125,6 +125,7 @@ namespace extension_manifest_values {
extern const char kIntentDispositionInline[];
extern const char kIsolatedStorage[];
extern const char kLaunchContainerPanel[];
+ extern const char kLaunchContainerShell[];
extern const char kLaunchContainerTab[];
extern const char kLaunchContainerWindow[];
extern const char kPageActionTypePermanent[];
@@ -196,6 +197,7 @@ namespace extension_manifest_errors {
extern const char kInvalidJsList[];
extern const char kInvalidKey[];
extern const char kInvalidLaunchContainer[];
+ extern const char kInvalidLaunchContainerForNonPlatform[];
extern const char kInvalidLaunchContainerForPlatform[];
extern const char kInvalidLaunchHeight[];
extern const char kInvalidLaunchHeightContainer[];
@@ -350,7 +352,8 @@ namespace extension_misc {
enum LaunchContainer {
LAUNCH_WINDOW,
LAUNCH_PANEL,
- LAUNCH_TAB
+ LAUNCH_TAB,
+ LAUNCH_SHELL
};
// The name of the apps promo histogram.
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/extension_constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698