chrome/browser/ui/gtk/browser_titlebar.cc - Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/browser_titlebar.cc

Issue 8734016: Make platform apps use and require a different container ("shell" instead of "panel") (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/browser_titlebar.cc

diff --git a/chrome/browser/ui/gtk/browser_titlebar.cc b/chrome/browser/ui/gtk/browser_titlebar.cc

index 1d28483032422b219b5ce953915def4c1bc0b863..98da9e7548800f7154c2f11d4a8ee1ae8d5aff15 100644

--- a/chrome/browser/ui/gtk/browser_titlebar.cc

+++ b/chrome/browser/ui/gtk/browser_titlebar.cc

@@ -624,6 +624,10 @@ void BrowserTitlebar::UpdateTitleAndIcon() {

NOTREACHED() << "We should never have a tabbed app window.";

break;

}

+ case Browser::TYPE_SHELL: {

+ // Shell windows don't show titles and icons for now.

+ break;

+ }

case Browser::TYPE_PANEL: {

break;

}

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/gtk/browser_window_gtk.cc » ('j') | no next file with comments »