Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 8676042: Remove Context3D/Surface3D (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
Reviewers:
tony, alokp
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, darin-cc_chromium.org, yzshen+watch_chromium.org, vrk (LEFT CHROMIUM), piman+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org, greggman
Visibility:
Public.

Description

Remove Context3D/Surface3D Graphics3D is the new black. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112412

Patch Set 1 #

Patch Set 2 : fix nacl #

Patch Set 3 : regen ppapi/c/private/ppb_flash_fullscreen.h #

Patch Set 4 : fix build #

Total comments: 3

Patch Set 5 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -3240 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 4 3 chunks +11 lines, -12 lines 0 comments Download
M ppapi/api/dev/ppb_video_decoder_dev.idl View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/dev/ppb_video_layer_dev.idl View 1 chunk +2 lines, -2 lines 0 comments Download
A ppapi/api/pp_graphics_3d.idl View 1 chunk +69 lines, -0 lines 0 comments Download
M ppapi/api/private/ppb_flash_fullscreen.idl View 1 chunk +5 lines, -5 lines 0 comments Download
D ppapi/c/dev/ppb_context_3d_dev.h View 1 chunk +0 lines, -124 lines 0 comments Download
D ppapi/c/dev/ppb_context_3d_trusted_dev.h View 1 chunk +0 lines, -108 lines 0 comments Download
D ppapi/c/dev/ppb_surface_3d_dev.h View 1 chunk +0 lines, -113 lines 0 comments Download
M ppapi/c/dev/ppb_video_decoder_dev.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/dev/ppb_video_layer_dev.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/c/pp_graphics_3d.h View 1 chunk +64 lines, -23 lines 0 comments Download
M ppapi/c/private/ppb_flash_fullscreen.h View 1 2 4 chunks +8 lines, -14 lines 0 comments Download
D ppapi/cpp/dev/context_3d_dev.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ppapi/cpp/dev/context_3d_dev.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/cpp/dev/surface_3d_dev.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ppapi/cpp/dev/surface_3d_dev.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/cpp/dev/video_decoder_dev.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ppapi/cpp/instance.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ppapi/cpp/instance.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_globals.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.h View 3 chunks +0 lines, -4 lines 0 comments Download
M ppapi/native_client/tests/ppapi_test_lib/get_browser_interface.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 6 chunks +0 lines, -11 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 3 4 chunks +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 3 chunks +0 lines, -61 lines 0 comments Download
D ppapi/proxy/ppb_context_3d_proxy.h View 1 chunk +0 lines, -141 lines 0 comments Download
D ppapi/proxy/ppb_context_3d_proxy.cc View 1 chunk +0 lines, -701 lines 0 comments Download
D ppapi/proxy/ppb_surface_3d_proxy.h View 1 chunk +0 lines, -99 lines 0 comments Download
D ppapi/proxy/ppb_surface_3d_proxy.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M ppapi/proxy/ppb_video_decoder_proxy.cc View 3 chunks +8 lines, -21 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 4 chunks +0 lines, -30 lines 0 comments Download
M ppapi/shared_impl/opengles2_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M ppapi/shared_impl/resource.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/shared_impl/video_decoder_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ppapi/shared_impl/video_decoder_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 4 chunks +1 line, -7 lines 0 comments Download
D ppapi/thunk/ppb_context_3d_api.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ppapi/thunk/ppb_context_3d_thunk.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D ppapi/thunk/ppb_context_3d_trusted_thunk.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M ppapi/thunk/ppb_gles_chromium_texture_mapping_thunk.cc View 3 chunks +7 lines, -29 lines 0 comments Download
D ppapi/thunk/ppb_surface_3d_api.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ppapi/thunk/ppb_surface_3d_thunk.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M ppapi/thunk/ppb_video_decoder_thunk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +0 lines, -11 lines 0 comments Download
M ppapi/thunk/thunk.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 chunks +0 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 9 chunks +0 lines, -32 lines 0 comments Download
D webkit/plugins/ppapi/ppb_context_3d_impl.h View 1 chunk +0 lines, -118 lines 0 comments Download
D webkit/plugins/ppapi/ppb_context_3d_impl.cc View 1 chunk +0 lines, -374 lines 0 comments Download
D webkit/plugins/ppapi/ppb_surface_3d_impl.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webkit/plugins/ppapi/ppb_surface_3d_impl.cc View 1 chunk +0 lines, -194 lines 0 comments Download
M webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 2 chunks +7 lines, -21 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 3 chunks +1 line, -12 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 5 chunks +2 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
tony:OWNERS in webkit/glue (gyp) alokp:please review
9 years ago (2011-11-30 01:20:07 UTC) #1
alokp
lgtm http://codereview.chromium.org/8676042/diff/1063/ppapi/thunk/interfaces_ppb_private.h File ppapi/thunk/interfaces_ppb_private.h (left): http://codereview.chromium.org/8676042/diff/1063/ppapi/thunk/interfaces_ppb_private.h#oldcode24 ppapi/thunk/interfaces_ppb_private.h:24: // at the ABI level. TODO(polina): remove this ...
9 years ago (2011-11-30 04:06:02 UTC) #2
piman
http://codereview.chromium.org/8676042/diff/1063/ppapi/thunk/interfaces_ppb_private.h File ppapi/thunk/interfaces_ppb_private.h (left): http://codereview.chromium.org/8676042/diff/1063/ppapi/thunk/interfaces_ppb_private.h#oldcode24 ppapi/thunk/interfaces_ppb_private.h:24: // at the ABI level. TODO(polina): remove this when ...
9 years ago (2011-11-30 06:02:04 UTC) #3
tony
rs LGTM
9 years ago (2011-11-30 18:33:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8676042/1063
9 years ago (2011-11-30 23:57:41 UTC) #5
commit-bot: I haz the power
Presubmit check for 8676042-1063 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-11-30 23:58:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8676042/12001
9 years ago (2011-12-01 00:20:57 UTC) #7
commit-bot: I haz the power
Try job failure for 8676042-12001 (retry) on win_rel for steps "browser_tests, ui_tests". It's a second ...
9 years ago (2011-12-01 03:00:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8676042/12001
9 years ago (2011-12-01 03:58:55 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-01 06:47:11 UTC) #10
Change committed as 112412

Powered by Google App Engine
This is Rietveld 408576698