Print Preview: Properly handle window.print().

Print Preview: Properly handle window.print().

BUG=92107
TEST=see bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111332

[Lei Zhang, 2011-11-10 23:17:00]

This is a CL that applies on top of http://codereview.chromium.org/8136027/

I previously had some of this code in the above CL, but decided splitting this
out is easier for reviewers. With this patch, we properly handle window.print(),
but we get into the weird case where other views in the same renderer are
frozen. Users who do not multitask much may not even notice.

After this, I'll work on fixing showModalDialog, and then make scripted print
preview modal.

[vandebo (ex-Chrome), 2011-11-10 23:59:59]

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:81: DCHECK_EQ(NOT_PREVIEWING,
print_preview_state_);
What if you close a tab/window while previewing?

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:128: // Check for spurious call.
This makes me sad.  If you can explain why there might be a spurious call that
we should ignore, explaining that here would make me less sad.

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:287: PrintNowInternal(new
PrintMsg_InitiatePrintPreview(routing_id()));
This will trigger GetPrintFrame(), but the caller already set the print frame.

[Lei Zhang, 2011-11-11 11:45:11]

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:81: DCHECK_EQ(NOT_PREVIEWING,
print_preview_state_);
On 2011/11/10 23:59:59, vandebo wrote:
> What if you close a tab/window while previewing?

RemoveInitiatorTab() will call PrintPreviewDone() first.

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:128: // Check for spurious call.
On 2011/11/10 23:59:59, vandebo wrote:
> This makes me sad.  If you can explain why there might be a spurious call that
> we should ignore, explaining that here would make me less sad.

This is a defensive move. I'll check whether it's needed or not.

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:287: PrintNowInternal(new
PrintMsg_InitiatePrintPreview(routing_id()));
On 2011/11/10 23:59:59, vandebo wrote:
> This will trigger GetPrintFrame(), but the caller already set the print frame.

I'm surprised this didn't blow up, fixed.

[Lei Zhang, 2011-11-11 22:34:25]

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
File chrome/browser/printing/print_view_manager.cc (right):

http://codereview.chromium.org/8515017/diff/1/chrome/browser/printing/print_v...
chrome/browser/printing/print_view_manager.cc:128: // Check for spurious call.
On 2011/11/10 23:59:59, vandebo wrote:
> This makes me sad.  If you can explain why there might be a spurious call that
> we should ignore, explaining that here would make me less sad.

Got rid of this and turned it into a DCHECK.

[vandebo (ex-Chrome), 2011-11-11 23:17:29]

LGTM

[darin (slow to review), 2011-11-14 22:34:06]

chrome/renderer/ change LGTM