chrome/browser/printing/print_preview_tab_controller.h - Issue 8515017: Print Preview: Properly handle window.print().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller.h

Issue 8515017: Print Preview: Properly handle window.print(). (Closed)

Patch Set: fail instead of crash when 2 views both do window.print() Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/print_preview_tab_controller.h

diff --git a/chrome/browser/printing/print_preview_tab_controller.h b/chrome/browser/printing/print_preview_tab_controller.h

index abd5056af98f04a144c4b6e0b384033cc0d31c1c..af23ca7ce8474dbb3dd37ec255a5342367976117 100644

--- a/chrome/browser/printing/print_preview_tab_controller.h

+++ b/chrome/browser/printing/print_preview_tab_controller.h

@@ -106,7 +106,8 @@ class PrintPreviewTabController

void RemoveObservers(TabContentsWrapper* tab);

// Removes tabs when they close/crash/navigate.

- void RemoveInitiatorTab(TabContentsWrapper* initiator_tab);

+ void RemoveInitiatorTab(TabContentsWrapper* initiator_tab,

+ bool is_navigation);

void RemovePreviewTab(TabContentsWrapper* preview_tab);

// Mapping between print preview tab and the corresponding initiator tab.