chrome/browser/printing/print_preview_tab_controller_browsertest.cc - Issue 8515017: Print Preview: Properly handle window.print().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

Issue 8515017: Print Preview: Properly handle window.print(). (Closed)

Patch Set: fail instead of crash when 2 views both do window.print() Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/printing/print_preview_tab_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_tab_controller_browsertest.cc b/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

index c8708272e836335539c58accb1bfb550f6861aaf..4dcf532486f4932504468ab337c803902f6ec57a 100644

--- a/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

@@ -4,6 +4,7 @@

#include "base/command_line.h"

#include "chrome/browser/printing/print_preview_tab_controller.h"

+#include "chrome/browser/printing/print_view_manager.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"

@@ -69,6 +70,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

+ initiator_tab->print_view_manager()->PrintPreviewNow();

TabContentsWrapper* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -85,6 +87,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(observer.tab_destroyed());

// Get the print preview tab for initiator tab.

+ initiator_tab->print_view_manager()->PrintPreviewNow();

TabContentsWrapper* new_preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -115,6 +118,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

+ initiator_tab->print_view_manager()->PrintPreviewNow();

TabContentsWrapper* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -134,6 +138,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_destroyed_observer.tab_destroyed());

// Get the print preview tab for initiator tab.

+ initiator_tab->print_view_manager()->PrintPreviewNow();

TabContentsWrapper* new_preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);