Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: chrome/browser/ui/webui/print_preview_handler_unittest.cc

Issue 8515017: Print Preview: Properly handle window.print(). (Closed)
Patch Set: fail instead of crash when 2 views both do window.print() Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_writer.h" 6 #include "base/json/json_writer.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/printing/background_printing_manager.h" 9 #include "chrome/browser/printing/background_printing_manager.h"
10 #include "chrome/browser/printing/print_preview_tab_controller.h" 10 #include "chrome/browser/printing/print_preview_tab_controller.h"
11 #include "chrome/browser/printing/print_view_manager.h"
11 #include "chrome/browser/ui/browser_list.h" 12 #include "chrome/browser/ui/browser_list.h"
12 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 13 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
13 #include "chrome/browser/ui/webui/print_preview_handler.h" 14 #include "chrome/browser/ui/webui/print_preview_handler.h"
14 #include "chrome/browser/ui/webui/print_preview_ui.h" 15 #include "chrome/browser/ui/webui/print_preview_ui.h"
15 #include "chrome/common/chrome_switches.h" 16 #include "chrome/common/chrome_switches.h"
16 #include "chrome/test/base/browser_with_test_window_test.h" 17 #include "chrome/test/base/browser_with_test_window_test.h"
17 #include "printing/page_size_margins.h" 18 #include "printing/page_size_margins.h"
18 #include "printing/print_job_constants.h" 19 #include "printing/print_job_constants.h"
19 20
20 namespace { 21 namespace {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 57
57 void OpenPrintPreviewTab() { 58 void OpenPrintPreviewTab() {
58 TabContentsWrapper* initiator_tab = 59 TabContentsWrapper* initiator_tab =
59 browser()->GetSelectedTabContentsWrapper(); 60 browser()->GetSelectedTabContentsWrapper();
60 ASSERT_TRUE(initiator_tab); 61 ASSERT_TRUE(initiator_tab);
61 62
62 printing::PrintPreviewTabController* controller = 63 printing::PrintPreviewTabController* controller =
63 printing::PrintPreviewTabController::GetInstance(); 64 printing::PrintPreviewTabController::GetInstance();
64 ASSERT_TRUE(controller); 65 ASSERT_TRUE(controller);
65 66
67 initiator_tab->print_view_manager()->PrintPreviewNow();
66 preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab); 68 preview_tab_ = controller->GetOrCreatePreviewTab(initiator_tab);
67 ASSERT_TRUE(preview_tab_); 69 ASSERT_TRUE(preview_tab_);
68 70
69 preview_ui_ = static_cast<PrintPreviewUI*>(preview_tab_->web_ui()); 71 preview_ui_ = static_cast<PrintPreviewUI*>(preview_tab_->web_ui());
70 ASSERT_TRUE(preview_ui_); 72 ASSERT_TRUE(preview_ui_);
71 } 73 }
72 74
73 void DeletePrintPreviewTab() { 75 void DeletePrintPreviewTab() {
74 printing::BackgroundPrintingManager* bg_printing_manager = 76 printing::BackgroundPrintingManager* bg_printing_manager =
75 g_browser_process->background_printing_manager(); 77 g_browser_process->background_printing_manager();
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 double margin_value; 285 double margin_value;
284 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop, 286 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginTop,
285 &margin_value)); 287 &margin_value));
286 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight, 288 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginRight,
287 &margin_value)); 289 &margin_value));
288 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom, 290 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginBottom,
289 &margin_value)); 291 &margin_value));
290 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft, 292 EXPECT_FALSE(initial_settings.GetDouble(printing::kSettingMarginLeft,
291 &margin_value)); 293 &margin_value));
292 } 294 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/print_preview_handler.cc ('k') | chrome/browser/ui/webui/print_preview_ui_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698