Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/printing/print_preview_tab_controller_unittest.cc

Issue 8515017: Print Preview: Properly handle window.print(). (Closed)
Patch Set: fail instead of crash when 2 views both do window.print() Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_tab_controller_unittest.cc
diff --git a/chrome/browser/printing/print_preview_tab_controller_unittest.cc b/chrome/browser/printing/print_preview_tab_controller_unittest.cc
index 1a01af086b57c5d5dffbbc6417eb616a76dc9c16..59c12bdd56a2a63ac88c2c772fead8b8e4ab9393 100644
--- a/chrome/browser/printing/print_preview_tab_controller_unittest.cc
+++ b/chrome/browser/printing/print_preview_tab_controller_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "chrome/browser/printing/print_preview_tab_controller.h"
+#include "chrome/browser/printing/print_view_manager.h"
#include "chrome/browser/tabs/tab_strip_model.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
@@ -46,6 +47,7 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_GetOrCreatePreviewTab) {
ASSERT_TRUE(tab_controller);
// Get the preview tab for initiator tab.
+ initiator_tab->print_view_manager()->PrintPreviewNow();
TabContentsWrapper* preview_tab =
tab_controller->GetOrCreatePreviewTab(initiator_tab);
@@ -98,6 +100,7 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_MultiplePreviewTabs) {
ASSERT_TRUE(tab_controller);
// Create preview tab for |tab_contents_1|
+ tab_contents_1->print_view_manager()->PrintPreviewNow();
TabContentsWrapper* preview_tab_1 =
tab_controller->GetOrCreatePreviewTab(tab_contents_1);
@@ -105,6 +108,7 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_MultiplePreviewTabs) {
EXPECT_EQ(2, browser()->tab_count());
// Create preview tab for |tab_contents_2|
+ tab_contents_2->print_view_manager()->PrintPreviewNow();
TabContentsWrapper* preview_tab_2 =
tab_controller->GetOrCreatePreviewTab(tab_contents_2);
@@ -158,6 +162,7 @@ TEST_F(PrintPreviewTabControllerUnitTest, MAYBE_ClearInitiatorTabDetails) {
ASSERT_TRUE(tab_controller);
// Get the preview tab for initiator tab.
+ initiator_tab->print_view_manager()->PrintPreviewNow();
TabContentsWrapper* preview_tab =
tab_controller->GetOrCreatePreviewTab(initiator_tab);
« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller_browsertest.cc ('k') | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698