Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). (Closed)

Created:
9 years, 1 month ago by tfarina
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). BUG=100276 R=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -22 lines) Patch
M chrome/browser/sidebar/sidebar_container.h View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/sidebar/sidebar_container.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
9 years, 1 month ago (2011-11-16 20:54:03 UTC) #1
Lei Zhang
9 years, 1 month ago (2011-11-16 20:56:49 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698