chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h - Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h

Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/blocked_content/blocked_content_container.cc ('k') | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h

diff --git a/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h b/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h

index 51ce822509bde04414268b6f115f935998591fd3..80a76ede08156f7d8f5a4b08af180202aa954c5b 100644

--- a/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h

+++ b/chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h

@@ -11,6 +11,8 @@

#include <set>

#include <vector>

+#include "base/basictypes.h"

+#include "base/compiler_specific.h"

#include "base/memory/scoped_ptr.h"

#include "base/timer.h"

#include "chrome/browser/ui/gtk/tabs/drag_data.h"

@@ -94,14 +96,13 @@ class DraggedTabControllerGtk : public content::NotificationObserver,

virtual TabContents* OpenURLFromTab(TabContents* source,

const OpenURLParams& params) OVERRIDE;

virtual void NavigationStateChanged(const TabContents* source,

- unsigned changed_flags);

+ unsigned changed_flags) OVERRIDE;

virtual void AddNewContents(TabContents* source,

TabContents* new_contents,

WindowOpenDisposition disposition,

const gfx::Rect& initial_pos,

- bool user_gesture);

- virtual void LoadingStateChanged(TabContents* source);

- virtual bool IsPopup(const TabContents* source) const;

+ bool user_gesture) OVERRIDE;

+ virtual void LoadingStateChanged(TabContents* source) OVERRIDE;

virtual content::JavaScriptDialogCreator*

GetJavaScriptDialogCreator() OVERRIDE;