chrome/browser/ui/blocked_content/blocked_content_container.h - Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/blocked_content_container.h

Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/blocked_content/blocked_content_container.h

diff --git a/chrome/browser/ui/blocked_content/blocked_content_container.h b/chrome/browser/ui/blocked_content/blocked_content_container.h

index c04d923f0c1dd9fb68eff2db3daa3705b962704e..c6a261e57d03d61344fd56b026f9ad0d5f788844 100644

--- a/chrome/browser/ui/blocked_content/blocked_content_container.h

+++ b/chrome/browser/ui/blocked_content/blocked_content_container.h

@@ -80,8 +80,7 @@ class BlockedContentContainer : public BlockedContentTabHelperDelegate,

// Changes the opening rectangle associated with |source|.

virtual void MoveContents(TabContents* source, const gfx::Rect& new_bounds);

- // Always returns true.

- virtual bool IsPopup(const TabContents* source) const;

+ virtual bool IsPopupOrPanel(const TabContents* source) const OVERRIDE;

// Always returns true.

virtual bool ShouldSuppressDialogs();

« no previous file with comments | « chrome/browser/sidebar/sidebar_container.cc ('k') | chrome/browser/ui/blocked_content/blocked_content_container.cc » ('j') | no next file with comments »