chrome/browser/ui/blocked_content/blocked_content_container.cc - Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/blocked_content_container.cc

Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/blocked_content/blocked_content_container.h ('k') | chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/blocked_content/blocked_content_container.cc

diff --git a/chrome/browser/ui/blocked_content/blocked_content_container.cc b/chrome/browser/ui/blocked_content/blocked_content_container.cc

index ab4fc117f9ac028ce58f2107f5bd2f02b707f72c..fb22816591ed1af643c5df61b588a11556c11a1c 100644

--- a/chrome/browser/ui/blocked_content/blocked_content_container.cc

+++ b/chrome/browser/ui/blocked_content/blocked_content_container.cc

@@ -161,7 +161,7 @@ void BlockedContentContainer::MoveContents(TabContents* source,

}

-bool BlockedContentContainer::IsPopup(const TabContents* source) const {

+bool BlockedContentContainer::IsPopupOrPanel(const TabContents* source) const {

// Assume everything added is a popup. This may turn out to be wrong, but

// callers don't cache this information so it should be fine if the value ends

// up changing.