Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc

Issue 8513023: Fix the remaining cases of classes implementing non-existent TabContentsDelegate::IsPopup(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h" 5 #include "chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 } 216 }
217 } 217 }
218 218
219 void DraggedTabControllerGtk::LoadingStateChanged(TabContents* source) { 219 void DraggedTabControllerGtk::LoadingStateChanged(TabContents* source) {
220 // TODO(jhawkins): It would be nice to respond to this message by changing the 220 // TODO(jhawkins): It would be nice to respond to this message by changing the
221 // screen shot in the dragged tab. 221 // screen shot in the dragged tab.
222 if (dragged_view_.get()) 222 if (dragged_view_.get())
223 dragged_view_->Update(); 223 dragged_view_->Update();
224 } 224 }
225 225
226 bool DraggedTabControllerGtk::IsPopup(const TabContents* source) const {
227 return false;
228 }
229
230 content::JavaScriptDialogCreator* 226 content::JavaScriptDialogCreator*
231 DraggedTabControllerGtk::GetJavaScriptDialogCreator() { 227 DraggedTabControllerGtk::GetJavaScriptDialogCreator() {
232 return GetJavaScriptDialogCreatorInstance(); 228 return GetJavaScriptDialogCreatorInstance();
233 } 229 }
234 230
235 //////////////////////////////////////////////////////////////////////////////// 231 ////////////////////////////////////////////////////////////////////////////////
236 // DraggedTabControllerGtk, content::NotificationObserver implementation: 232 // DraggedTabControllerGtk, content::NotificationObserver implementation:
237 233
238 void DraggedTabControllerGtk::Observe( 234 void DraggedTabControllerGtk::Observe(
239 int type, 235 int type,
(...skipping 660 matching lines...) Expand 10 before | Expand all | Expand 10 after
900 896
901 bool DraggedTabControllerGtk::AreTabsConsecutive() { 897 bool DraggedTabControllerGtk::AreTabsConsecutive() {
902 for (size_t i = 1; i < drag_data_->size(); ++i) { 898 for (size_t i = 1; i < drag_data_->size(); ++i) {
903 if (drag_data_->get(i - 1)->source_model_index_ + 1 != 899 if (drag_data_->get(i - 1)->source_model_index_ + 1 !=
904 drag_data_->get(i)->source_model_index_) { 900 drag_data_->get(i)->source_model_index_) {
905 return false; 901 return false;
906 } 902 }
907 } 903 }
908 return true; 904 return true;
909 } 905 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698